Bug 222917

Summary: REGRESSION (r274033): [ macOS/iOS ] model-element/model-element-ready-load-aborted.html is text failing
Product: WebKit Reporter: Robert Jenner <jenner>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
222917-test list
none
Patch none

Robert Jenner
Reported 2021-03-08 09:29:37 PST
model-element/model-element-ready-load-aborted.html is a consistent text failure in macOS. HISTORY URL: https://results.webkit.org/?suite=layout-tests&test=model-element%2Fmodel-element-ready-load-aborted.html TEXT DIFF: --- /Volumes/Data/worker/bigsur-release-tests-wk2/build/layout-test-results/model-element/model-element-ready-load-aborted-expected.txt +++ /Volumes/Data/worker/bigsur-release-tests-wk2/build/layout-test-results/model-element/model-element-ready-load-aborted-actual.txt @@ -1,3 +1,3 @@ This test passes if you see the word "Passed" below: -Passed +Failed. Model should not have loaded, but did. History indicates failures consistently started occurring at r274033.It appears there were changes made that appear related to this test. https://trac.webkit.org/changeset/274033/webkit
Attachments
222917-test list (454.93 KB, text/plain)
2021-03-08 12:06 PST, Robert Jenner 		no flags
Details
Patch (1.67 KB, patch)
2021-03-08 15:45 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-08 09:29:58 PST
<rdar://problem/75173628>
Robert Jenner
Comment 2 2021-03-08 09:32:02 PST
I haven't reproduced the issue yet, but it does appear to have a clear regression point. Running the test standalone does not produce the failure.
Robert Jenner
Comment 3 2021-03-08 12:06:41 PST
Created attachment 422600 [details] 222917-test list Test list for reproducing "model-element/model-element-ready-load-aborted.html" text failure.
Robert Jenner
Comment 4 2021-03-08 12:26:55 PST
I was able to reproduce the failure at tip of tree using the attached test, and running it as: run-webkit-test --root <path to revision> <path to test list> --debug --child-process=1 By eliminating tests from the test list, I was able to deduce that when the test: model-element/model-element-graphics-layers.html is ran before: model-element/model-element-ready-load-aborted.html it causes a consistent text failure. When the test: model-element/model-element-graphics-layers.html is removed, and the entire suite of 7000+ tests is ran again without it, model-element/model-element-ready-load-aborted.html passes.
Tim Horton
Comment 5 2021-03-08 14:02:17 PST
Sam and I think we see the mistake in the test
Tim Horton
Comment 6 2021-03-08 15:45:01 PST
Created attachment 422626 [details] Patch
EWS
Comment 7 2021-03-08 17:50:05 PST
Committed r274126: <https://commits.webkit.org/r274126> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422626 [details].
Note You need to log in before you can comment on or make changes to this bug.