Bug 222881

Summary:

[GPU Process] Test under http/tests/canvas/color-font fail when GPU process rendering is enabled for 2D Canvas

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

Canvas

Assignee:

Cameron McCormack (:heycam) <heycam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, heycam, jonlee, mmaxfield, rini_patel, sabouhallawa, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=225959

Bug Depends on:

Bug Blocks:

222835, 225583

Attachments:

Description	Flags
Patch	none

Description Said Abou-Hallawa 2021-03-07 01:06:04 PST

These tests seem flaky when GPU rendering is enabled for 2D Canvas:

http/tests/canvas/color-fonts/fill-gradient-sbix-2.html
http/tests/canvas/color-fonts/fill-gradient-sbix-3.html
http/tests/canvas/color-fonts/fill-gradient-sbix-4.html
http/tests/canvas/color-fonts/stroke-gradient-sbix-2.html
http/tests/canvas/color-fonts/stroke-gradient-sbix-3.html
http/tests/canvas/color-fonts/stroke-gradient-sbix-4.html

Comment 1 Radar WebKit Bug Importer 2021-03-07 19:27:32 PST

<rdar://problem/75155310>

Comment 2 Simon Fraser (smfr) 2021-03-10 11:57:38 PST

*** Bug 223034 has been marked as a duplicate of this bug. ***

Comment 3 Cameron McCormack (:heycam) 2021-05-09 17:20:18 PDT

Created attachment 428144 [details]
Patch

Comment 4 Myles C. Maxfield 2021-05-09 20:44:01 PDT

At first glance this looks great. However I want to go in a bit more detail on Monday about trying to figure out if the code this patch adds is sufficient to handle having two contexts share the same recorder.

Comment 5 EWS 2021-05-18 21:21:21 PDT

Committed r277715 (237894@main): <https://commits.webkit.org/237894@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428144 [details].