Bug 222873 – REGRESSION(r274041): Broke the build instead of fixing it

• Component: New Bugs
• Status: RESOLVED FIXED

[WebKit Commit Bot]

https://trac.webkit.org/changeset/274041 broke the build:
Broke the build instead of fixing it

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.

[WebKit Commit Bot]

Created attachment 422512 [details]
REVERT of r274041

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[EWS]

Committed r274045: <https://commits.webkit.org/r274045>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422512 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75138138>

[Sam Weinig]

If we do add this back at any point, probably makes more sense to do it in the definition of DECLARE_CALL_FRAME, where the __builtin_frame_address(1) actually is.

But it would also be good to understand the original error which was (as I understand it):

./dfg/DFGOSRExit.cpp:225:28: error: calling '__builtin_frame_address' with a nonzero argument is unsafe [-Werror,-Wframe-address]
    CallFrame* callFrame = DECLARE_CALL_FRAME(vm);
                           

Since we explicitly call:

        bitwise_cast<JSC::CallFrame*>(__builtin_frame_address(1)); \

It seems like we are doing something clang does not like.

Looks like there was some discussion of this in rdar://70421807 / https://bugs.webkit.org/show_bug.cgi?id=217588.