Bug 222868

Summary: Transition Cocoa DumpRenderTree to allow any preference keys, not just hard coded supported ones
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Sam Weinig 2021-03-06 12:24:59 PST
Transition Cocoa DumpRenderTree to allow any preference key, not just hard codded supported one
Comment 1 Sam Weinig 2021-03-06 12:30:48 PST Comment hidden (obsolete)
Comment 2 Sam Weinig 2021-03-06 18:21:55 PST
Created attachment 422515 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-03-07 09:28:45 PST
Comment on attachment 422515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422515&action=review

> Tools/DumpRenderTree/TestOptions.cpp:123
> +            { "AspectRatioOfImgFromWidthAndHeightEnabled", false },
> +            { "AsyncClipboardAPIEnabled", false },
> +            { "CSSOMViewSmoothScrollingEnabled", false },
> +            { "ContactPickerAPIEnabled", false },
> +            { "CoreMathMLEnabled", false },
> +            { "GenericCueAPIEnabled", false },
> +            { "IntersectionObserverEnabled", false },
> +            { "IsLoggedInAPIEnabled", false },
> +            { "LazyIframeLoadingEnabled", false },
> +            { "LazyImageLoadingEnabled", false },
> +            { "RequestIdleCallbackEnabled", false },
> +            { "ResizeObserverEnabled", false },
> +            { "WebAuthenticationEnabled", false },
> +            { "WebGPUEnabled", false },

Seems like at least some of these should just be enabled in WK1. Like, AspectRatioOfImgFromWidthAndHeightEnabled is purely about layout.
Comment 4 EWS 2021-03-07 09:41:55 PST
Committed r274052: <https://commits.webkit.org/r274052>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422515 [details].
Comment 5 Radar WebKit Bug Importer 2021-03-07 09:42:17 PST
<rdar://problem/75148917>