Bug 222851

Summary: [RenderTreeBuilder] Readjust the first child when it is the multicolumn container
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2021-03-05 20:05:52 PST
<rdar://problem/73392642>
Attachments
Patch (4.74 KB, patch)
2021-03-05 20:11 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (4.70 KB, patch)
2021-03-05 20:19 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2021-03-05 20:11:38 PST
Created attachment 422467 [details] Patch
Simon Fraser (smfr)
Comment 2 2021-03-05 20:13:43 PST
Comment on attachment 422467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422467&action=review > Source/WebCore/rendering/updating/RenderTreeBuilderBlockFlow.cpp:53 > + beforeChild = beforeChild == multicolumnFlow ? multicolumnFlow->firstChild() : beforeChild; A little hard to read. also a space at the end.
alan
Comment 3 2021-03-05 20:19:48 PST
Created attachment 422469 [details] Patch
EWS
Comment 4 2021-03-06 04:59:10 PST
Committed r274035: <https://commits.webkit.org/r274035> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422469 [details].
Note You need to log in before you can comment on or make changes to this bug.