Bug 222836

Summary: [GPUP] Move GPUProcess WebGL to Experimental Feature
Product: WebKit Reporter: Jon Lee <jonlee>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, dino, ews-watchlist, glenn, jbedard, kbr, kkinnunen, peng.liu6, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 217211    
Attachments:
Description Flags
EWS test
none
Patch
none
Patch none

Jon Lee
Reported 2021-03-05 15:24:48 PST
[GPUP] Enable WebGL in layout tests by default
Attachments
EWS test (1.25 KB, patch)
2021-03-05 15:29 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (17.40 KB, patch)
2021-03-18 04:36 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (6.09 KB, patch)
2021-05-03 02:58 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jon Lee
Comment 1 2021-03-05 15:25:01 PST
rdar://75048190
Jon Lee
Comment 2 2021-03-05 15:29:37 PST
Created attachment 422439 [details] EWS test
Peng Liu
Comment 3 2021-03-17 11:22:03 PDT
Comment on attachment 422439 [details] EWS test View in context: https://bugs.webkit.org/attachment.cgi?id=422439&action=review > Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:174 > + return true; This will enable the feature by default, not only for WKTR.
Kimmo Kinnunen
Comment 4 2021-03-17 11:23:03 PDT
Yeah, I'll revise (change the yamls)
Kimmo Kinnunen
Comment 5 2021-03-18 04:36:23 PDT
Created attachment 423586 [details] Patch
Peng Liu
Comment 6 2021-03-22 09:41:38 PDT
Comment on attachment 423586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423586&action=review > Source/WTF/ChangeLog:10 > + external in order to make WebGL use GPU process in s/external/experimental/g?
Jon Lee
Comment 7 2021-03-29 11:22:33 PDT
Can we revise this patch to move the flag to experimental, but keep it OFF on layout tests?
Kimmo Kinnunen
Comment 8 2021-05-03 02:58:47 PDT
Created attachment 427547 [details] Patch
Brent Fulgham
Comment 9 2021-05-03 17:26:29 PDT
Comment on attachment 427547 [details] Patch r=me
EWS
Comment 10 2021-05-03 23:34:03 PDT
Committed r276948 (237281@main): <https://commits.webkit.org/237281@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427547 [details].
Note You need to log in before you can comment on or make changes to this bug.