Bug 222824

Summary: [Big Sur arm64] TestWebKitAPI.WebKit.AccessibilityReduceMotion is a flaky crash
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cfleizach, pvollan, sam, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
crash log
none
Patch thorton: review+

Ryan Haddad
Reported 2021-03-05 13:58:20 PST
Created attachment 422414 [details] crash log TestWebKitAPI.WebKit.AccessibilityReduceMotion is a flaky crash on the (new) Big Sur Apple Silicon bots Thread 8 Crashed:: Dispatch queue: com.apple.root.default-qos 0 libobjc.A.dylib 0x00000001a58ab178 objc_msgSend + 24 1 com.apple.WebKit 0x000000010b8f6eec -[WKUserDefaults findPreferenceChangesAndNotifyForKeys:toValuesForKeys:] + 924 (PreferenceObserver.mm:81) 2 com.apple.WebKit 0x000000010b8f73dc -[WKUserDefaults _notifyObserversOfChangeFromValuesForKeys:toValuesForKeys:]::$_1::operator()() const + 100 (PreferenceObserver.mm:98) 3 com.apple.WebKit 0x000000010b8f736c __76-[WKUserDefaults _notifyObserversOfChangeFromValuesForKeys:toValuesForKeys:]_block_invoke + 28 (PreferenceObserver.mm:97) 4 libdispatch.dylib 0x00000001a58638bc _dispatch_call_block_and_release + 32 5 libdispatch.dylib 0x00000001a5865420 _dispatch_client_callout + 20 6 libdispatch.dylib 0x00000001a58760d8 _dispatch_root_queue_drain + 656 7 libdispatch.dylib 0x00000001a58767a4 _dispatch_worker_thread2 + 116 8 libsystem_pthread.dylib 0x00000001a5a0e024 _pthread_wqthread + 216 9 libsystem_pthread.dylib 0x00000001a5a0cd94 start_wqthread + 8 https://build.webkit.org/#/builders/103/builds/19/steps/11/logs/stdio https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebKit.AccessibilityReduceMotion
Attachments
crash log (99.82 KB, text/plain)
2021-03-05 13:58 PST, Ryan Haddad 		no flags
Details
Patch (2.64 KB, patch)
2021-03-29 15:41 PDT, Alex Christensen 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-05 13:58:29 PST
<rdar://problem/75110622>
Ryan Haddad
Comment 2 2021-03-29 13:02:39 PDT
Disabled the test for arm64 in https://trac.webkit.org/changeset/275170/webkit
Ryan Haddad
Comment 3 2021-03-29 13:47:40 PDT
Reverted r275170 for reason: Broke the build Committed r275175 (235878@main): <https://commits.webkit.org/235878@main>
Alex Christensen
Comment 4 2021-03-29 15:41:31 PDT
Created attachment 424595 [details] Patch
Alex Christensen
Comment 5 2021-03-29 15:48:58 PDT
I hit the same crash before but not after this. Let's see if it fixes the bots too
Alex Christensen
Comment 6 2021-03-29 15:57:25 PDT
r275188
Alex Christensen
Comment 7 2021-03-29 20:08:49 PDT
Seems to have fixed it.
Note You need to log in before you can comment on or make changes to this bug.