Bug 222823 – REGRESSION: [iOS] http/tests/security/strip-referrer-to-origin-for-third-party-redirects-in-private-mode.html is failing

• Component: New Bugs
• Status: RESOLVED FIXED

[Ryan Haddad]

http/tests/security/strip-referrer-to-origin-for-third-party-redirects-in-private-mode.html is failing on iOS bots:

--- /Volumes/Data/worker/ios-simulator-14-release-tests-wk2/build/layout-test-results/http/tests/security/strip-referrer-to-origin-for-third-party-redirects-in-private-mode-expected.txt
+++ /Volumes/Data/worker/ios-simulator-14-release-tests-wk2/build/layout-test-results/http/tests/security/strip-referrer-to-origin-for-third-party-redirects-in-private-mode-actual.txt
@@ -12,4 +12,8 @@
 --------
 Frame: '<!--frame1-->'
 --------
-http://127.0.0.1:8000/
+Not Found
+
+The requested URL was not found on this server.
+
+Apache/2.4.41 (Unix) PHP/7.3.11 LibreSSL/2.8.3 Server at 127.0.0.1 Port 80

https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fsecurity%2Fstrip-referrer-to-origin-for-third-party-redirects-in-private-mode.html

[Ryan Haddad]

I think this broke with the PHP -> Python conversion in https://trac.webkit.org/changeset/272981/webkit

[Ryan Haddad]

EWS missed this because the test is marked as a flaky timeout, so it was skipped.

[Jonathan Bedard]

I'll look into this Monday. Seems likely to do with 'allowCache'.

[Chris Gambrell]

Created attachment 422446 [details]
Patch for EWS

[Darin Adler]

Comment on attachment 422446 [details]
Patch for EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=422446&action=review

> LayoutTests/ChangeLog:9
> +        * http/tests/resources/redirect.py:
> +        (addCacheControl):

Normally we explain what we changed and why it fixes the bug.

[Ryan Haddad]

Comment on attachment 422446 [details]
Patch for EWS

Not yet ready for review.

[Jonathan Bedard]

Comment on attachment 422446 [details]
Patch for EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=422446&action=review

> LayoutTests/http/tests/resources/redirect.py:33
>      sys.exit(0)

This looks wrong.

[Chris Gambrell]

Created attachment 422456 [details]
Patch

[Chris Gambrell]

Comment on attachment 422456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422456&action=review

> LayoutTests/http/tests/security/strip-referrer-to-origin-for-third-party-redirects-in-private-mode.html:-30
> -        openIframe("resources/redirect.py?redirectTo=http://localhost:8000/security/resources/echo-referrer.php", finishJSTest);

"resources/redirect.py" was thought to be referencing LayoutTests/http/tests/resources/redirect.py when in actuality it was referencing LayoutTests/http/tests/security/resources/redirect.py which does not exist. Corrected back to "resources/redirect.php"

[Radar WebKit Bug Importer]

<rdar://problem/75133450>

[Chris Gambrell]

Created attachment 422571 [details]
Patch

[EWS]

Committed r274075: <https://commits.webkit.org/r274075>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422571 [details].