Bug 222818

Summary: [GTK] Clean up GTK-specific text checker stuff
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, don.olmstead, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
See Also: https://bugs.webkit.org/show_bug.cgi?id=181916
Attachments:
Description Flags
Patch
none
Patch for landing none

Michael Catanzaro
Reported 2021-03-05 13:00:18 PST
This moves GTK-specific classes into GTK-specific directories. It also exposes WKTextCheckerSetContinuousSpellCheckingEnabled and uses it in UIScriptControllerGtk, which is needed for bug #181916. This code is pretty messy, but now it's a *platform-specific* mess, which is a small improvement.
Attachments
Patch (51.16 KB, patch)
2021-03-05 13:37 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch for landing (50.93 KB, patch)
2021-03-05 14:41 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2021-03-05 13:04:51 PST
Ah drat, I thought it was entirely GTK-specific, but I missed WKTextCheckerSetTestingMode, which is really cross-platform. Need to change a few things.
Michael Catanzaro
Comment 2 2021-03-05 13:37:19 PST
Created attachment 422406 [details] Patch
Don Olmstead
Comment 3 2021-03-05 14:26:54 PST
Comment on attachment 422406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422406&action=review > Source/WebKit/UIProcess/API/C/WKTextChecker.h:26 > > -#ifndef WKTextChecker_h > -#define WKTextChecker_h > +#pragma once Any public C API header should have the #ifndef guards. > Source/WebKit/UIProcess/API/C/gtk/WKTextCheckerGtk.h:26 > -#ifndef WKTextCheckerGtk_h > -#define WKTextCheckerGtk_h > +#pragma once Should be #ifndef guards
Michael Catanzaro
Comment 4 2021-03-05 14:41:23 PST
Created attachment 422425 [details] Patch for landing
EWS
Comment 5 2021-03-05 15:07:40 PST
Committed r274011: <https://commits.webkit.org/r274011> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422425 [details].
Note You need to log in before you can comment on or make changes to this bug.