Bug 222815 – [Big Sur arm64] testb3 crashing

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Ryan Haddad]

Created attachment 422393 [details]
crash log

testb3 is crashing on the (new) Apple-BigSur-AppleSilicon-Release-JSC-Tests bot

Thread 3 Crashed:: testb3 thread
0   testb3                        	0x0000000104d18df8 void checkDisassembly<checkUsesInstruction(JSC::Compilation&, char const*)::'lambda'(char const*)>(JSC::Compilation&, checkUsesInstruction(JSC::Compilation&, char const*)::'lambda'(char const*) const&, WTF::CString const&) (.cold.1) + 64 (testb3.h:244)
1   testb3                        	0x0000000104d18df8 void checkDisassembly<checkUsesInstruction(JSC::Compilation&, char const*)::'lambda'(char const*)>(JSC::Compilation&, checkUsesInstruction(JSC::Compilation&, char const*)::'lambda'(char const*) const&, WTF::CString const&) (.cold.1) + 64 (testb3.h:243)
2   testb3                        	0x0000000104bec098 void checkDisassembly<checkUsesInstruction(JSC::Compilation&, char const*)::'lambda'(char const*)>(JSC::Compilation&, checkUsesInstruction(JSC::Compilation&, char const*)::'lambda'(char const*) const&, WTF::CString const&) + 168 (testb3.h:241)
3   testb3                        	0x0000000104bc6924 checkUsesInstruction(JSC::Compilation&, char const*) + 164 (testb3.h:249)
4   testb3                        	0x0000000104ccf6ac testMemoryFence() + 336 (testb3_6.cpp:2604)
5   testb3                        	0x0000000104bb209c run(char const*)::$_553::operator()() const + 84 (testb3_1.cpp:751)
6   testb3                        	0x0000000104bb2008 WTF::SharedTaskFunctor<void (), run(char const*)::$_553>::run() + 28 (SharedTask.h:91)
7   testb3                        	0x0000000104bc51d8 run(char const*)::$_617::operator()() const + 296 (testb3_1.cpp:874)
8   testb3                        	0x0000000104bc5018 WTF::Detail::CallableWrapper<run(char const*)::$_617, void>::call() + 28 (Function.h:52)
9   com.apple.JavaScriptCore      	0x0000000105840808 operator() + 16 (Function.h:83) [inlined]
10  com.apple.JavaScriptCore      	0x0000000105840808 WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 136 (Threading.cpp:181)
11  com.apple.JavaScriptCore      	0x0000000105842b30 WTF::wtfThreadEntryPoint(void*) + 12 (ThreadingPOSIX.cpp:241)
12  libsystem_pthread.dylib       	0x000000019cd0e06c _pthread_start + 320
13  libsystem_pthread.dylib       	0x000000019cd08da0 thread_start + 8

https://build.webkit.org/#/builders/102/builds/14

[Radar WebKit Bug Importer]

<rdar://problem/75106256>

[Yusuke Suzuki]

Created attachment 423119 [details]
Patch

[Mark Lam]

Comment on attachment 423119 [details]
Patch

It's unfortunate that the test is so fragile as to require a specific number of spaces in the disassembly, but I suppose this is the simplest fix and it is adequate because a wrong number of spaces is noticeable as it did fail with an error.

r=me

[EWS]

Committed r274402: <https://commits.webkit.org/r274402>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423119 [details].