Bug 222815

Summary: [Big Sur arm64] testb3 crashing
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bot-watchers-bugzilla, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
crash log
none
Patch none

Description Ryan Haddad 2021-03-05 12:15:26 PST
Created attachment 422393 [details]
crash log

testb3 is crashing on the (new) Apple-BigSur-AppleSilicon-Release-JSC-Tests bot

Thread 3 Crashed:: testb3 thread
0   testb3                        	0x0000000104d18df8 void checkDisassembly<checkUsesInstruction(JSC::Compilation&, char const*)::'lambda'(char const*)>(JSC::Compilation&, checkUsesInstruction(JSC::Compilation&, char const*)::'lambda'(char const*) const&, WTF::CString const&) (.cold.1) + 64 (testb3.h:244)
1   testb3                        	0x0000000104d18df8 void checkDisassembly<checkUsesInstruction(JSC::Compilation&, char const*)::'lambda'(char const*)>(JSC::Compilation&, checkUsesInstruction(JSC::Compilation&, char const*)::'lambda'(char const*) const&, WTF::CString const&) (.cold.1) + 64 (testb3.h:243)
2   testb3                        	0x0000000104bec098 void checkDisassembly<checkUsesInstruction(JSC::Compilation&, char const*)::'lambda'(char const*)>(JSC::Compilation&, checkUsesInstruction(JSC::Compilation&, char const*)::'lambda'(char const*) const&, WTF::CString const&) + 168 (testb3.h:241)
3   testb3                        	0x0000000104bc6924 checkUsesInstruction(JSC::Compilation&, char const*) + 164 (testb3.h:249)
4   testb3                        	0x0000000104ccf6ac testMemoryFence() + 336 (testb3_6.cpp:2604)
5   testb3                        	0x0000000104bb209c run(char const*)::$_553::operator()() const + 84 (testb3_1.cpp:751)
6   testb3                        	0x0000000104bb2008 WTF::SharedTaskFunctor<void (), run(char const*)::$_553>::run() + 28 (SharedTask.h:91)
7   testb3                        	0x0000000104bc51d8 run(char const*)::$_617::operator()() const + 296 (testb3_1.cpp:874)
8   testb3                        	0x0000000104bc5018 WTF::Detail::CallableWrapper<run(char const*)::$_617, void>::call() + 28 (Function.h:52)
9   com.apple.JavaScriptCore      	0x0000000105840808 operator() + 16 (Function.h:83) [inlined]
10  com.apple.JavaScriptCore      	0x0000000105840808 WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 136 (Threading.cpp:181)
11  com.apple.JavaScriptCore      	0x0000000105842b30 WTF::wtfThreadEntryPoint(void*) + 12 (ThreadingPOSIX.cpp:241)
12  libsystem_pthread.dylib       	0x000000019cd0e06c _pthread_start + 320
13  libsystem_pthread.dylib       	0x000000019cd08da0 thread_start + 8

https://build.webkit.org/#/builders/102/builds/14
Comment 1 Radar WebKit Bug Importer 2021-03-05 12:15:36 PST
<rdar://problem/75106256>
Comment 2 Yusuke Suzuki 2021-03-14 00:31:56 PST
Created attachment 423119 [details]
Patch
Comment 3 Mark Lam 2021-03-14 08:57:17 PDT
Comment on attachment 423119 [details]
Patch

It's unfortunate that the test is so fragile as to require a specific number of spaces in the disassembly, but I suppose this is the simplest fix and it is adequate because a wrong number of spaces is noticeable as it did fail with an error.

r=me
Comment 4 EWS 2021-03-14 13:26:12 PDT
Committed r274402: <https://commits.webkit.org/r274402>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423119 [details].