Bug 222813

Summary: [JSC] ARM64 branchAtomicWeakCAS should not use sign-extension
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, sbarati, tzagallo, webkit-bot-watchers-bugzilla, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Ryan Haddad 2021-03-05 12:08:11 PST
Seeing these failures on the (new) Big Sur Apple Silicon JSC queues

** The following JSC stress test failures have been introduced:
	stress/atomic-store-result-type-in-ai.js.default
	stress/atomics-store-result-int52.js.bytecode-cache
	stress/atomics-store-result-int52.js.dfg-eager
	stress/atomics-store-result-int52.js.dfg-eager-no-cjit-validate
	stress/atomics-store-result-int52.js.eager-jettison-no-cjit
	stress/atomics-store-result-int52.js.ftl-eager
	stress/atomics-store-result-int52.js.ftl-no-cjit-b3o0
	stress/atomics-store-result-int52.js.ftl-no-cjit-no-inline-validate
	stress/atomics-store-result-int52.js.ftl-no-cjit-no-put-stack-validate
	stress/atomics-store-result-int52.js.ftl-no-cjit-small-pool
	stress/atomics-store-result-int52.js.ftl-no-cjit-validate-sampling-profiler
	stress/atomics-store-result-int52.js.no-cjit-collect-continuously
	stress/atomics-store-result-int52.js.no-cjit-validate-phases
	stress/atomics-store-result-int52.js.no-ftl
	stress/atomics-store-result.js.bytecode-cache
	stress/atomics-store-result.js.dfg-eager
	stress/atomics-store-result.js.dfg-eager-no-cjit-validate
	stress/atomics-store-result.js.eager-jettison-no-cjit
	stress/atomics-store-result.js.ftl-eager
	stress/atomics-store-result.js.ftl-no-cjit-b3o0
	stress/atomics-store-result.js.ftl-no-cjit-no-inline-validate
	stress/atomics-store-result.js.ftl-no-cjit-no-put-stack-validate
	stress/atomics-store-result.js.ftl-no-cjit-small-pool
	stress/atomics-store-result.js.ftl-no-cjit-validate-sampling-profiler
	stress/atomics-store-result.js.mini-mode
	stress/atomics-store-result.js.no-cjit-collect-continuously
	stress/atomics-store-result.js.no-cjit-validate-phases

https://build.webkit.org/#/builders/102/builds/14/steps/9/logs/stdio
Comment 1 Ryan Haddad 2021-03-05 12:08:33 PST
rdar://74288466
Comment 2 Yusuke Suzuki 2021-03-14 00:18:34 PST
Created attachment 423118 [details]
Patch
Comment 3 Mark Lam 2021-03-14 08:43:51 PDT
Comment on attachment 423118 [details]
Patch

r=me
Comment 4 EWS 2021-03-14 13:22:28 PDT
Committed r274401: <https://commits.webkit.org/r274401>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423118 [details].