Bug 222778

Summary: Add internal preference to disable HTTPS upgrade
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: ASSIGNED    
Severity: Normal CC: simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Alex Christensen
Reported 2021-03-04 21:19:37 PST
Add internal preference to disable HTTPS upgrade
Attachments
Patch (3.41 KB, patch)
2021-03-04 21:22 PST, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-03-04 21:22:29 PST
Created attachment 422335 [details] Patch
EWS
Comment 2 2021-03-04 23:05:53 PST
Committed r273950: <https://commits.webkit.org/r273950> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422335 [details].
Radar WebKit Bug Importer
Comment 3 2021-03-04 23:06:16 PST
<rdar://problem/75080279>
Simon Fraser (smfr)
Comment 4 2021-03-08 10:05:05 PST
This isn't how preferences normally work.
Simon Fraser (smfr)
Comment 5 2021-03-08 10:06:00 PST
The right way do use the configuration and preferences here is to have the configuration option feed into a preference (and setting in WebCore). So Page::m_httpsUpgradeEnabled should not exist; that should just be a Setting.
Note You need to log in before you can comment on or make changes to this bug.