Bug 222778

Summary: Add internal preference to disable HTTPS upgrade
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: ASSIGNED ---    
Severity: Normal CC: simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch ews-feeder: commit-queue-

Description Alex Christensen 2021-03-04 21:19:37 PST
Add internal preference to disable HTTPS upgrade
Comment 1 Alex Christensen 2021-03-04 21:22:29 PST
Created attachment 422335 [details]
Comment 2 EWS 2021-03-04 23:05:53 PST
Committed r273950: <https://commits.webkit.org/r273950>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422335 [details].
Comment 3 Radar WebKit Bug Importer 2021-03-04 23:06:16 PST
Comment 4 Simon Fraser (smfr) 2021-03-08 10:05:05 PST
This isn't how preferences normally work.
Comment 5 Simon Fraser (smfr) 2021-03-08 10:06:00 PST
The right way do use the configuration and preferences here is to have the configuration option feed into a preference (and setting in WebCore). So Page::m_httpsUpgradeEnabled should not exist; that should just be a Setting.