Bug 222774

Summary: Canvas: drawImage should normalize srcRect before checking if it's empty
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: CanvasAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, bugs-noreply, cdumez, changseok, clord, darin, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Lauro Moura
Reported 2021-03-04 19:09:56 PST
Canvas: drawImage should normalize srcRect before checking if it's empty
Attachments
Patch (2.39 KB, patch)
2021-03-04 19:12 PST, Lauro Moura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2021-03-04 19:12:55 PST
Created attachment 422321 [details] Patch
EWS
Comment 2 2021-03-05 09:30:28 PST
commit-queue failed to commit attachment 422321 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 3 2021-03-05 10:41:36 PST
commit-queue failed to commit attachment 422321 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 4 2021-03-05 11:26:52 PST
Committed r273986: <https://commits.webkit.org/r273986> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422321 [details].
Radar WebKit Bug Importer
Comment 5 2021-03-05 11:27:13 PST
<rdar://problem/75103972>
Darin Adler
Comment 6 2021-03-05 15:07:51 PST
Comment on attachment 422321 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422321&action=review > Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:1697 > + if (!srcBitmapRect.contains(normalizedSrcRect) || !dstRect.width() || !dstRect.height()) Is the rendering correct in all the cases below when srcRect gets normalized? Noting that the code below uses srcRect not normalizedSrcRect.
Note You need to log in before you can comment on or make changes to this bug.