Bug 222754

Summary: [resultsdbpy] Adopt webkitscmpy
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=222762
https://bugs.webkit.org/show_bug.cgi?id=222766
https://bugs.webkit.org/show_bug.cgi?id=221860
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2021-03-04 11:32:01 PST
resultsdbpy needs to adopt identifiers. Rather than reimplement identifier computation implemented by webkitscmpy, we should just use webkitscmpy.
Attachments
Patch (170.46 KB, patch)
2021-03-04 11:57 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (170.47 KB, patch)
2021-03-05 10:20 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (170.51 KB, patch)
2021-03-08 10:19 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-04 11:34:54 PST
<rdar://problem/75049209>
Jonathan Bedard
Comment 2 2021-03-04 11:57:09 PST
Created attachment 422268 [details] Patch
Jonathan Bedard
Comment 3 2021-03-05 10:20:21 PST
Created attachment 422380 [details] Patch
dewei_zhu
Comment 4 2021-03-08 10:00:03 PST
r=me
Jonathan Bedard
Comment 5 2021-03-08 10:19:08 PST
Created attachment 422581 [details] Patch for landing
EWS
Comment 6 2021-03-08 11:12:19 PST
Committed r274084: <https://commits.webkit.org/r274084> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422581 [details].
Note You need to log in before you can comment on or make changes to this bug.