Summary: | REGRESSION (r272376): [iOS] ASSERTION FAILED: sessionID.isEphemeral() || !path.isEmpty() in WebKit::NetworkProcess::swServerForSession | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, cdumez, commit-queue, ggaren, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=221384 | ||||||||
Bug Depends on: | 223023 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Ryan Haddad
2021-03-03 23:36:49 PST
Test history suggests that this regressed with https://trac.webkit.org/changeset/272376/webkit After more tries than I would like to admit, I finally got an iOS simulator and build to reproduce this. Fixing... Created attachment 422377 [details]
Patch
Comment on attachment 422377 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422377&action=review r=me > Source/WebKit/NetworkProcess/NetworkProcess.cpp:432 > if (isNewEntry) > SandboxExtension::consumePermanently(cacheRootPathHandle); > + else > + ASSERT_NOT_REACHED(); I would just ASSERT(isNewEntry). Then no need for if/else. Comment on attachment 422377 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422377&action=review > Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h:51 > + ~NetworkProcessCreationParameters(); Why are we adding this? > Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h:52 > + NetworkProcessCreationParameters& operator=(NetworkProcessCreationParameters&&); ditto. Why are we not getting an implicit one? Comment on attachment 422377 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422377&action=review > Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h:50 > + NetworkProcessCreationParameters(NetworkProcessCreationParameters&&); Ditto. We should be getting an implicit one here. Why do we need to define it explicitly? Comment on attachment 422377 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422377&action=review >> Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h:51 >> + ~NetworkProcessCreationParameters(); > > Why are we adding this? I need to add a non-inline destructor so we don't need to include the definition of WebsiteDataStoreParameters here. Because I added that, we need the others. (In reply to Alex Christensen from comment #8) > Comment on attachment 422377 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=422377&action=review > > >> Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h:51 > >> + ~NetworkProcessCreationParameters(); > > > > Why are we adding this? > > I need to add a non-inline destructor so we don't need to include the > definition of WebsiteDataStoreParameters here. Because I added that, we > need the others. OK. Makes sense then. Thanks. Re-opened since this is blocked by bug 223023 Created attachment 424254 [details]
Patch
Committed r275047: <https://commits.webkit.org/r275047> All reviewed patches have been landed. Closing bug and clearing flags on attachment 424254 [details]. |