Bug 222639

Summary: Web Inspector: `RecordCanvasActionVariant` causes a huge symbol to be created in WebCore
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, hi, inspector-bugzilla-changes, japhet, joepeck, keith_miller, kondapallykalyan, mark.lam, msaboff, saam, thorton, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Devin Rousso
Reported 2021-03-02 19:41:24 PST
.
Attachments
Patch (144.41 KB, patch)
2021-03-02 20:07 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (141.41 KB, patch)
2021-03-02 20:11 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (141.66 KB, patch)
2021-03-02 21:12 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (142.35 KB, patch)
2021-03-03 16:42 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-03-02 19:41:39 PST
<rdar://problem/73728057>
Devin Rousso
Comment 2 2021-03-02 20:07:32 PST
Created attachment 422036 [details] Patch
Devin Rousso
Comment 3 2021-03-02 20:11:21 PST
Created attachment 422037 [details] Patch rebase
EWS Watchlist
Comment 4 2021-03-02 20:12:19 PST
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Devin Rousso
Comment 5 2021-03-02 21:12:40 PST
Created attachment 422039 [details] Patch
Blaze Burg
Comment 6 2021-03-03 09:17:16 PST
Comment on attachment 422039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422039&action=review r=me, nice work! > Source/WebCore/ChangeLog:25 > + way (and the tests confirm it). Do tests need to sort the result before dumping it to ensure they aren't flakey?
Devin Rousso
Comment 7 2021-03-03 16:25:44 PST
Comment on attachment 422039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422039&action=review >> Source/WebCore/ChangeLog:25 >> + way (and the tests confirm it). > > Do tests need to sort the result before dumping it to ensure they aren't flakey? Actually no, because we don't dump the literal JSON payload in the test, we dump the recording data after deduplicating/swizzling :)
Devin Rousso
Comment 8 2021-03-03 16:42:37 PST
Created attachment 422161 [details] Patch
EWS
Comment 9 2021-03-03 17:34:26 PST
Committed r273865: <https://commits.webkit.org/r273865> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422161 [details].
Note You need to log in before you can comment on or make changes to this bug.