Bug 222639

Summary: Web Inspector: `RecordCanvasActionVariant` causes a huge symbol to be created in WebCore
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, hi, inspector-bugzilla-changes, japhet, joepeck, keith_miller, kondapallykalyan, mark.lam, msaboff, saam, thorton, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Devin Rousso 2021-03-02 19:41:24 PST
.
Comment 1 Devin Rousso 2021-03-02 19:41:39 PST
<rdar://problem/73728057>
Comment 2 Devin Rousso 2021-03-02 20:07:32 PST
Created attachment 422036 [details]
Patch
Comment 3 Devin Rousso 2021-03-02 20:11:21 PST
Created attachment 422037 [details]
Patch

rebase
Comment 4 EWS Watchlist 2021-03-02 20:12:19 PST
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Comment 5 Devin Rousso 2021-03-02 21:12:40 PST
Created attachment 422039 [details]
Patch
Comment 6 BJ Burg 2021-03-03 09:17:16 PST
Comment on attachment 422039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422039&action=review

r=me, nice work!

> Source/WebCore/ChangeLog:25
> +        way (and the tests confirm it).

Do tests need to sort the result before dumping it to ensure they aren't flakey?
Comment 7 Devin Rousso 2021-03-03 16:25:44 PST
Comment on attachment 422039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422039&action=review

>> Source/WebCore/ChangeLog:25
>> +        way (and the tests confirm it).
> 
> Do tests need to sort the result before dumping it to ensure they aren't flakey?

Actually no, because we don't dump the literal JSON payload in the test, we dump the recording data after deduplicating/swizzling :)
Comment 8 Devin Rousso 2021-03-03 16:42:37 PST
Created attachment 422161 [details]
Patch
Comment 9 EWS 2021-03-03 17:34:26 PST
Committed r273865: <https://commits.webkit.org/r273865>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422161 [details].