Bug 222610

Summary: [Cocoa] REGRESSION(r272752): fix some internal builds that use WTFString::WTFString(NSString *)
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bburg, cdumez, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1.0
none
Patch v1.0
none
Patch
none
Patch none

Blaze Burg
Reported 2021-03-02 11:28:40 PST
.
Attachments
Patch v1.0 (2.57 KB, patch)
2021-03-02 11:38 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch v1.0 (11.66 KB, patch)
2021-03-02 11:53 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch (4.85 KB, patch)
2021-03-04 11:33 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (4.36 KB, patch)
2021-03-04 19:27 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2021-03-02 11:29:03 PST
<rdar://74938249>
Blaze Burg
Comment 2 2021-03-02 11:38:30 PST
Created attachment 421970 [details] Patch v1.0
EWS Watchlist
Comment 3 2021-03-02 11:39:41 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Blaze Burg
Comment 4 2021-03-02 11:53:11 PST
Created attachment 421973 [details] Patch v1.0
Alex Christensen
Comment 5 2021-03-02 12:03:20 PST
r273751
Alex Christensen
Comment 6 2021-03-04 11:33:44 PST
Reopening to attach new patch.
Alex Christensen
Comment 7 2021-03-04 11:33:46 PST
Created attachment 422264 [details] Patch
Alex Christensen
Comment 8 2021-03-04 11:40:08 PST
r273906
Alex Christensen
Comment 9 2021-03-04 14:06:16 PST
http://trac.webkit.org/r273917
Alex Christensen
Comment 10 2021-03-04 19:23:51 PST
Comment on attachment 422264 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422264&action=review > Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:399 > + return 'fromProtocolString<%s>((__bridge CFStringRef)%s)' % (self.objc_enum_name_for_non_anonymous_enum(parameter.type), name) This is the one that broke the internal build. Will verify everything works without it then recommit
Alex Christensen
Comment 11 2021-03-04 19:27:38 PST
Created attachment 422324 [details] Patch
Alex Christensen
Comment 12 2021-03-04 20:17:53 PST
http://trac.webkit.org/r273940
Note You need to log in before you can comment on or make changes to this bug.