Summary: | [Cocoa] REGRESSION(r272752): fix some internal builds that use WTFString::WTFString(NSString *) | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||||||
Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, bburg, cdumez, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
BJ Burg
2021-03-02 11:28:40 PST
Created attachment 421970 [details]
Patch v1.0
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) Created attachment 421973 [details]
Patch v1.0
Reopening to attach new patch. Created attachment 422264 [details]
Patch
Comment on attachment 422264 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422264&action=review > Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:399 > + return 'fromProtocolString<%s>((__bridge CFStringRef)%s)' % (self.objc_enum_name_for_non_anonymous_enum(parameter.type), name) This is the one that broke the internal build. Will verify everything works without it then recommit Created attachment 422324 [details]
Patch
|