Summary: | Two build fixes for WebKit trunk against Symbian S60 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Hausmann <hausmann> | ||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Simon Hausmann
2008-11-14 03:58:18 PST
Created attachment 25170 [details]
Patch to fix compilation with WINSCW
We did not find a way to make the protection against the conversion from pointers to booleans to integers work with WINSCW, hence the #ifdef in the patch. But we would like to disable the protection in that case - in order to achieve compilation - and rely on the protection to work on the actual development platforms.
Created attachment 25171 [details]
Simple workaround for RVCT compiler bug
This rather simple patch works around a bug in RVCT. I would normally not try to submit this as it is a compiler bug, but given the difficulty of changing RVCT and the simplicity I thought it's worth a try :-)
Comment on attachment 25170 [details]
Patch to fix compilation with WINSCW
Code change looks OK, but it uses tabs, so we can't check it in as-is.
I'll say r=me, but to save work for committers please don't put patches up for review if they have tabs. Maybe the Qt folks can configure their git repository to catch this?
Comment on attachment 25171 [details]
Simple workaround for RVCT compiler bug
Looks fine, r=me
|