Bug 222561

Summary: [WPE][GTK] Remove webkit_website_data_manager_[get,set]_tls_errors_policy
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED WONTFIX    
Severity: Normal CC: berto, bugs-noreply, cgarcia, ews-watchlist, gustavo, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
See Also: https://bugs.webkit.org/show_bug.cgi?id=222366
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Michael Catanzaro
Reported 2021-03-01 10:11:44 PST
See discussion in bug #222366 for why these exist. We had to deprecate the original WebKitWebContext APIs, because the original functions cannot work properly anymore. But fact is, it's 2021. It's unacceptable for any application to use WEBKIT_TLS_ERRORS_POLICY_IGNORE. I think no apps use it, so no point in adding replacement functions.
Attachments
Patch (31.53 KB, patch)
2021-03-01 14:18 PST, Michael Catanzaro 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2021-03-01 14:18:04 PST
Created attachment 421866 [details] Patch
EWS Watchlist
Comment 2 2021-03-01 14:19:11 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Michael Catanzaro
Comment 3 2021-03-01 14:19:23 PST
Let me know what you think, please. This is intended to be applied to 2.32 branch before the first stable release there. The network proxy settings function is harder, but at least this is a simple solution to avoid the misplaced TLS functions.
Carlos Garcia Campos
Comment 4 2021-03-01 22:44:16 PST
I don't see any reason to remove this, to be honest. Ignoring tls errors is not enabled by default.
Michael Catanzaro
Comment 5 2021-03-02 06:14:31 PST
If you don't want to land it, please close this issue.
Carlos Garcia Campos
Comment 6 2021-03-03 00:04:55 PST
We can discuss the removal of this api as part fo the gtk4 api break.
Note You need to log in before you can comment on or make changes to this bug.