Bug 222533 – Reduce promise reaction memory usage when there are multiple reactions

• Component: New Bugs
• Status: RESOLVED FIXED

[Keith Miller]

Reduce promise reaction memory usage when there are multiple reactions

[Keith Miller]

Created attachment 421783 [details]
Patch

[Keith Miller]

Created attachment 421839 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 421839 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421839&action=review

r=me with comment.

> Source/JavaScriptCore/ChangeLog:14
> +        Previously, we would store each reaction in a linked list. This
> +        meant each reaction required 8 bytes to point to the next
> +        reaction.  Instead, this patch makes it so the first reaction is
> +        store inline an object and any additional reactions are store into
> +        index storage for that object. This doesn't save memory for the
> +        first reaction since we now need to have a count of all the out of
> +        line reactions but extra reactions use 8 bytes less each.

Does it show RAMification improvement?

> Source/JavaScriptCore/builtins/PromiseOperations.js:153
> +    var isResolved = state == @promiseStateFulfilled;

Use `===` instead of `==`.

[Keith Miller]

Comment on attachment 421839 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421839&action=review

>> Source/JavaScriptCore/ChangeLog:14
>> +        line reactions but extra reactions use 8 bytes less each.
> 
> Does it show RAMification improvement?

No, sadly :(

>> Source/JavaScriptCore/builtins/PromiseOperations.js:153
>> +    var isResolved = state == @promiseStateFulfilled;
> 
> Use `===` instead of `==`.

Oof, done!

[Keith Miller]

Created attachment 421887 [details]
Patch for landing

[EWS]

Committed r273718: <https://commits.webkit.org/r273718>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421887 [details].

[Radar WebKit Bug Importer]

<rdar://problem/74903266>