Bug 222461

Summary: [GPUP] Allow painting of GPUP hosted video from the WebContent process
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, eric.carlson, ews-watchlist, glenn, graouts, kkinnunen, kondapallykalyan, peng.liu6, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=222268
https://bugs.webkit.org/show_bug.cgi?id=221823
https://bugs.webkit.org/show_bug.cgi?id=221825
https://bugs.webkit.org/show_bug.cgi?id=221838
https://bugs.webkit.org/show_bug.cgi?id=221820
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Jer Noble
Reported 2021-02-25 23:13:33 PST
[GPUP] Allow painting of GPUP hosted video from the WebContent process
Attachments
Patch (22.96 KB, patch)
2021-02-25 23:21 PST, Jer Noble 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (25.65 KB, patch)
2021-02-25 23:55 PST, Jer Noble 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (25.88 KB, patch)
2021-02-26 00:15 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-02-25 23:19:38 PST
<rdar://problem/74778890>
Jer Noble
Comment 2 2021-02-25 23:21:48 PST
Created attachment 421616 [details] Patch
Jer Noble
Comment 3 2021-02-25 23:55:48 PST
Created attachment 421618 [details] Patch
Jer Noble
Comment 4 2021-02-26 00:15:44 PST
Created attachment 421619 [details] Patch
Eric Carlson
Comment 5 2021-02-26 08:28:54 PST
Comment on attachment 421619 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421619&action=review > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:304 > + auto status = CVPixelBufferCreateWithIOSurface(kCFAllocatorDefault, m_surface.get(), nullptr, &rawBuffer); Don't we want the pixel buffer to be GL/GLES compatible if possible? If so, see `ImageTransferSessionVT::ioSurfacePixelBufferCreationOptions`.
Jer Noble
Comment 6 2021-02-26 09:28:32 PST
(In reply to Eric Carlson from comment #5) > Comment on attachment 421619 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=421619&action=review > > > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:304 > > + auto status = CVPixelBufferCreateWithIOSurface(kCFAllocatorDefault, m_surface.get(), nullptr, &rawBuffer); > > Don't we want the pixel buffer to be GL/GLES compatible if possible? > > If so, see `ImageTransferSessionVT::ioSurfacePixelBufferCreationOptions`. Because we're merely transferring an existing IOSurface, that presumably is already GL compatible due to the flags we pass into the AVPlayerItemVideoOutput, I don't think we need to do any conformance here. But I'll look into this to make sure the resulting pixel buffer _is_ GL compatible.
EWS
Comment 7 2021-02-26 11:28:42 PST
Committed r273568: <https://commits.webkit.org/r273568> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421619 [details].
Peng Liu
Comment 8 2021-02-26 14:56:24 PST
*** Bug 221791 has been marked as a duplicate of this bug. ***
Peng Liu
Comment 9 2021-02-26 15:01:52 PST
*** Bug 221790 has been marked as a duplicate of this bug. ***
Peng Liu
Comment 10 2021-02-26 15:03:40 PST
*** Bug 221806 has been marked as a duplicate of this bug. ***
Peng Liu
Comment 11 2021-02-26 15:05:40 PST
*** Bug 221797 has been marked as a duplicate of this bug. ***
Peng Liu
Comment 12 2021-02-26 15:07:50 PST
*** Bug 221838 has been marked as a duplicate of this bug. ***
Peng Liu
Comment 13 2021-02-26 15:10:09 PST
*** Bug 221823 has been marked as a duplicate of this bug. ***
Peng Liu
Comment 14 2021-02-26 15:12:52 PST
*** Bug 221825 has been marked as a duplicate of this bug. ***
Peng Liu
Comment 15 2021-02-26 15:15:41 PST
*** Bug 221818 has been marked as a duplicate of this bug. ***
Peng Liu
Comment 16 2021-02-26 16:04:46 PST
*** Bug 222268 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.