Bug 222459

Summary: Remove ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING which is always true for macOS
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: WebKit Misc.Assignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dino, ews-watchlist, graouts, kondapallykalyan, pvollan, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch sam: review+

Simon Fraser (smfr)
Reported 2021-02-25 22:03:44 PST
Remove ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING whicih is always true for macOS
Attachments
Patch (41.86 KB, patch)
2021-02-25 22:07 PST, Simon Fraser (smfr) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (41.85 KB, patch)
2021-02-25 22:14 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (41.65 KB, patch)
2021-02-26 11:24 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (41.86 KB, patch)
2021-02-26 13:45 PST, Simon Fraser (smfr) 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-02-25 22:07:05 PST
Created attachment 421610 [details] Patch
Simon Fraser (smfr)
Comment 2 2021-02-25 22:14:20 PST
Created attachment 421611 [details] Patch
Simon Fraser (smfr)
Comment 3 2021-02-26 11:24:55 PST
Created attachment 421681 [details] Patch
Simon Fraser (smfr)
Comment 4 2021-02-26 13:45:32 PST
Created attachment 421704 [details] Patch
Sam Weinig
Comment 5 2021-02-26 16:34:58 PST
Comment on attachment 421704 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421704&action=review > Source/WTF/ChangeLog:8 > + ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING is always defined for PLATFORM(MAC), so remove it, > + replacing with PLATFORM(MAC) in a few places. In order to reduce the number PLATFORM(MAC), define > + HAVE(CVDISPLAYLINK) and use it in WK2 code that relates to DisplayLinks. I kinda feel like this is the opposite direction we should be going in. In general, I would like to discourage the use of PLATFORM(MAC), as it is not very self documenting.
Per Arne Vollan
Comment 6 2021-03-01 05:50:45 PST
Comment on attachment 421704 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421704&action=review > Source/WebKit/WebProcess/WebProcess.cpp:159 > +#if PLATFORM(MAC) > +#include <WebCore/DisplayRefreshMonitorManager.h> > +#endif Should this be HAVE(CVDISPLAYLINK)? > Source/WebKit/WebProcess/WebProcess.cpp:1879 > -#if ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) > +#if PLATFORM(MAC) Ditto.
Simon Fraser (smfr)
Comment 7 2021-03-01 11:15:24 PST
https://trac.webkit.org/changeset/273657/webkit
Radar WebKit Bug Importer
Comment 8 2021-03-01 11:16:15 PST
<rdar://problem/74880016>
Note You need to log in before you can comment on or make changes to this bug.