Bug 222438

Summary:

Emoji sequences with constituents in the UBLOCK_SYMBOLS_AND_PICTOGRAPHS_EXTENDED_A Unicode block don't get combined properly

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	zalan: review+, ews-feeder: commit-queue-
Patch for committing	none
Patch for committing	none
Patch for committing	ews-feeder: commit-queue-

Description Myles C. Maxfield 2021-02-25 13:55:27 PST

Emoji sequences with constituents in the UBLOCK_SYMBOLS_AND_PICTOGRAPHS_EXTENDED_A Unicode block don't get combined properly

Comment 1 Myles C. Maxfield 2021-02-25 13:56:02 PST

Created attachment 421561 [details]
Patch

Comment 2 Myles C. Maxfield 2021-02-25 13:56:05 PST

<rdar://problem/74152743>

Comment 3 Myles C. Maxfield 2021-02-25 14:16:16 PST

Created attachment 421565 [details]
Patch

Comment 4 Myles C. Maxfield 2021-02-25 14:35:01 PST

Created attachment 421566 [details]
Patch for committing

Comment 5 Myles C. Maxfield 2021-02-25 14:54:58 PST

Created attachment 421570 [details]
Patch for committing

Comment 6 Alexey Proskuryakov 2021-02-25 14:59:05 PST

Comment on attachment 421570 [details]
Patch for committing

View in context: https://bugs.webkit.org/attachment.cgi?id=421570&action=review

> Source/WebCore/ChangeLog:5
> +        <rdar://problem/74152743>

Is this the right radar for this?

Comment 7 Myles C. Maxfield 2021-02-25 15:15:15 PST

Comment on attachment 421570 [details]
Patch for committing

View in context: https://bugs.webkit.org/attachment.cgi?id=421570&action=review

>> Source/WebCore/ChangeLog:5
>> +        <rdar://problem/74152743>
> 
> Is this the right radar for this?

74382039

Comment 8 Myles C. Maxfield 2021-02-25 15:15:27 PST

<rdar://problem/74382039>

Comment 9 Myles C. Maxfield 2021-02-25 15:19:12 PST

Created attachment 421573 [details]
Patch for committing

Comment 10 Myles C. Maxfield 2021-02-25 19:47:49 PST

Committed r273539 (234602@main): <https://commits.webkit.org/234602@main>

Comment 11 Myles C. Maxfield 2021-02-26 10:44:37 PST

Committed r273567 (234624@main): <https://commits.webkit.org/234624@main>

Comment 12 Darin Adler 2021-03-01 14:11:57 PST

Comment on attachment 421573 [details]
Patch for committing

View in context: https://bugs.webkit.org/attachment.cgi?id=421573&action=review

> Source/WebCore/platform/text/CharacterProperties.h:34
> +#define SYMBOLS_AND_PICTOGRAPHS_EXTENDED_A 298

Could use constexpr instead of #define. What’s nice about this is that the scope would be limited to the function instead of leaking out.

> Source/WebCore/platform/text/CharacterProperties.h:36
> +#define UBLOCK_SYMBOLS_AND_PICTOGRAPHS_EXTENDED_A SYMBOLS_AND_PICTOGRAPHS_EXTENDED_A

Ditto.