Bug 222438

Summary: Emoji sequences with constituents in the UBLOCK_SYMBOLS_AND_PICTOGRAPHS_EXTENDED_A Unicode block don't get combined properly
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
zalan: review+, ews-feeder: commit-queue-
Patch for committing
none
Patch for committing
none
Patch for committing ews-feeder: commit-queue-

Myles C. Maxfield
Reported 2021-02-25 13:55:27 PST
Emoji sequences with constituents in the UBLOCK_SYMBOLS_AND_PICTOGRAPHS_EXTENDED_A Unicode block don't get combined properly
Attachments
Patch (3.22 KB, patch)
2021-02-25 13:56 PST, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (3.70 KB, patch)
2021-02-25 14:16 PST, Myles C. Maxfield 		zalan: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for committing (4.90 KB, patch)
2021-02-25 14:35 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch for committing (5.05 KB, patch)
2021-02-25 14:54 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch for committing (5.04 KB, patch)
2021-02-25 15:19 PST, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-02-25 13:56:02 PST
Created attachment 421561 [details] Patch
Myles C. Maxfield
Comment 2 2021-02-25 13:56:05 PST
<rdar://problem/74152743>
Myles C. Maxfield
Comment 3 2021-02-25 14:16:16 PST
Created attachment 421565 [details] Patch
Myles C. Maxfield
Comment 4 2021-02-25 14:35:01 PST
Created attachment 421566 [details] Patch for committing
Myles C. Maxfield
Comment 5 2021-02-25 14:54:58 PST
Created attachment 421570 [details] Patch for committing
Alexey Proskuryakov
Comment 6 2021-02-25 14:59:05 PST
Comment on attachment 421570 [details] Patch for committing View in context: https://bugs.webkit.org/attachment.cgi?id=421570&action=review > Source/WebCore/ChangeLog:5 > + <rdar://problem/74152743> Is this the right radar for this?
Myles C. Maxfield
Comment 7 2021-02-25 15:15:15 PST
Comment on attachment 421570 [details] Patch for committing View in context: https://bugs.webkit.org/attachment.cgi?id=421570&action=review >> Source/WebCore/ChangeLog:5 >> + <rdar://problem/74152743> > > Is this the right radar for this? 74382039
Myles C. Maxfield
Comment 8 2021-02-25 15:15:27 PST
<rdar://problem/74382039>
Myles C. Maxfield
Comment 9 2021-02-25 15:19:12 PST
Created attachment 421573 [details] Patch for committing
Myles C. Maxfield
Comment 10 2021-02-25 19:47:49 PST
Committed r273539 (234602@main): <https://commits.webkit.org/234602@main>
Myles C. Maxfield
Comment 11 2021-02-26 10:44:37 PST
Committed r273567 (234624@main): <https://commits.webkit.org/234624@main>
Darin Adler
Comment 12 2021-03-01 14:11:57 PST
Comment on attachment 421573 [details] Patch for committing View in context: https://bugs.webkit.org/attachment.cgi?id=421573&action=review > Source/WebCore/platform/text/CharacterProperties.h:34 > +#define SYMBOLS_AND_PICTOGRAPHS_EXTENDED_A 298 Could use constexpr instead of #define. What’s nice about this is that the scope would be limited to the function instead of leaking out. > Source/WebCore/platform/text/CharacterProperties.h:36 > +#define UBLOCK_SYMBOLS_AND_PICTOGRAPHS_EXTENDED_A SYMBOLS_AND_PICTOGRAPHS_EXTENDED_A Ditto.
Note You need to log in before you can comment on or make changes to this bug.