Bug 222434 – Add some exception checks to the bindings generator

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Saam Barati]

...

[Saam Barati]

<rdar://69066130>

[Saam Barati]

Created attachment 421560 [details]
patch

[Yusuke Suzuki]

Comment on attachment 421560 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421560&action=review

r=me, looks good!

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1261
>          push(@$outputArray, "    if (pluginElementCustomPut(thisObject, lexicalGlobalObject, propertyName, value, putPropertySlot, putResult))\n");
>          push(@$outputArray, "        return putResult;\n\n");
> +        push(@$outputArray, "    RETURN_IF_EXCEPTION(throwScope, false);\n");

I wonder if we need to put `RETURN_IF_EXCEPTION(throwScope, false)` even in `true` case of pluginElementCustomPut.

bool success = pluginElementCustomPut(...);
RETURN_IF_EXCEPTION(throwScope, false);
if (success)
    return putResult;

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1266
>      push(@$outputArray, "    return JSObject::put(thisObject, lexicalGlobalObject, propertyName, value, putPropertySlot);\n");

How about using this instead?

RELEASE_AND_RETURN(throwScope, JSObject::put(thisObject, lexicalGlobalObject, propertyName, value, putPropertySlot));

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1342
>          push(@$outputArray, "    if (pluginElementCustomPut(thisObject, lexicalGlobalObject, propertyName, value, putPropertySlot, putResult))\n");
>          push(@$outputArray, "        return putResult;\n\n");
> +        push(@$outputArray, "    RETURN_IF_EXCEPTION(throwScope, false);\n");

Ditto.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1348
>          push(@$outputArray, "    return JSObject::putByIndex(cell, lexicalGlobalObject, index, value, shouldThrow);\n");

Ditto about RELEASE_AND_RETURN.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1506
>      push(@$outputArray, "    return JSObject::defineOwnProperty(object, lexicalGlobalObject, propertyName, newPropertyDescriptor, shouldThrow);\n");

Ditto about RELEASE_AND_RETURN.

[Saam Barati]

Comment on attachment 421560 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421560&action=review

>> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1261
>> +        push(@$outputArray, "    RETURN_IF_EXCEPTION(throwScope, false);\n");
> 
> I wonder if we need to put `RETURN_IF_EXCEPTION(throwScope, false)` even in `true` case of pluginElementCustomPut.
> 
> bool success = pluginElementCustomPut(...);
> RETURN_IF_EXCEPTION(throwScope, false);
> if (success)
>     return putResult;

yeah, I think this is the right way to do it. I'll fix.

>> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1266
>>      push(@$outputArray, "    return JSObject::put(thisObject, lexicalGlobalObject, propertyName, value, putPropertySlot);\n");
> 
> How about using this instead?
> 
> RELEASE_AND_RETURN(throwScope, JSObject::put(thisObject, lexicalGlobalObject, propertyName, value, putPropertySlot));

yeah, I can do that.

[Saam Barati]

Created attachment 421567 [details]
patch for landing

[EWS]

Committed r273524: <https://commits.webkit.org/r273524>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421567 [details].