Bug 222405 – Now Playing is not working when GPUP Media is enabled

• Component: Media
• Status: RESOLVED FIXED

[Jean-Yves Avenard [:jya]]

Now Playing is not working when GPUP Media is enabled

[Jean-Yves Avenard [:jya]]

Created attachment 421506 [details]
Patch

[Eric Carlson]

Comment on attachment 421506 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421506&action=review

> Source/WebCore/ChangeLog:16
> +        MediaSessionManagerCocoa::setNowPlayingInfo would have always been called
> +        with false (setAsNowPlayingApplication) when the GPU process was in use.
> +        It needed to be called at least once.
> +        MRMediaRemoteSetCanBeNowPlayingApplication is fairly CPU intensive, so we
> +        ensure we only call it if no content had been played before and never again.

This comment isn't quite accurate because we will need to call `MRMediaRemoteSetCanBeNowPlayingApplication(true)` again if we want to become the NowPlaying application after having called `MRMediaRemoteSetCanBeNowPlayingApplication(false)`. 

Your code change works because we clear `m_nowPlayingInfo` if we call `MRMediaRemoteSetCanBeNowPlayingApplication(false)`, so I think only the comment needs too be updated.

[Jean-Yves Avenard [:jya]]

Created attachment 421582 [details]
Patch

[Jean-Yves Avenard [:jya]]

Created attachment 421583 [details]
Patch

[EWS]

Committed r273523: <https://commits.webkit.org/r273523>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421583 [details].

[Radar WebKit Bug Importer]

<rdar://problem/74769938>

[Michael Catanzaro]

Reopening to attach new patch.

[Michael Catanzaro]

Created attachment 421867 [details]
Patch for landing

[EWS]

Committed r273697: <https://commits.webkit.org/r273697>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421867 [details].