Bug 22240 – Add ifdef around toJS function in Plugin.h

• Component: Plug-ins
• Status: RESOLVED FIXED

[John Abd-El-Malek]

Need this change in order to get the file to compile in Chromium.

[John Abd-El-Malek]

Created attachment 25139 [details]
patch

[Darin Adler]

Comment on attachment 25139 [details]
patch

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 38377)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,11 @@
> [phone]  jabdelmalek  <set EMAIL_ADDRESS environment variable>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        WARNING: NO TEST CASES ADDED OR CHANGED
> +
> +        * plugins/Plugin.h:

This is not a sufficient ChangeLog. You need to put your name in, your email address, remove the "WARNING" message since this doesn't need test cases, add the URL of the bug you're fixing, and add a comment explaining the change you're making.

The code change is great. I'm going to say review- since it should be easy for you to make a good ChangeLog and re-post the patch with that included.

[John Abd-El-Malek]

Created attachment 25147 [details]
patch2

[John Abd-El-Malek]

Comment on attachment 25147 [details]
patch2

Thanks for the info, sorry I haven't sent a patch in a long time (and not with this email) so I forgot that I have to edit the changelog.  Updated patch.

[Darin Adler]

Comment on attachment 25147 [details]
patch2

r=me

[Sam Weinig]

Comment on attachment 25147 [details]
patch2

I don't think the #ifdef is necessary as the code can be removed.  JSPlugin.cpp now includes JSMimeType.h

[John Abd-El-Malek]

Created attachment 25175 [details]
3rd try

You're correct, although the toJS declarations were different (using MimeType vs  Plugin pointers).  I took out the line and verified that the build works.

[Sam Weinig]

This has been fixed, though I don't believe by the attached patch.  Closing.