Bug 222331

Summary: Fix MetalANGLE backend crashes in video texture tests
Product: WebKit Reporter: Kyle Piddington <kpiddington>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, jonlee, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 220076    
Attachments:
Description Flags
Patch
none
Patch dino: review+

Kyle Piddington
Reported 2021-02-23 13:34:59 PST
Fix MetalANGLE backend crashes in video texture tests
Attachments
Patch (39.42 KB, patch)
2021-02-23 13:35 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch (41.63 KB, patch)
2021-02-25 14:48 PST, Kyle Piddington 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kyle Piddington
Comment 1 2021-02-23 13:35:22 PST
Created attachment 421347 [details] Patch
EWS Watchlist
Comment 2 2021-02-23 13:36:30 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kyle Piddington
Comment 3 2021-02-25 14:48:17 PST
Created attachment 421569 [details] Patch
Dean Jackson
Comment 4 2021-02-25 15:15:39 PST
Comment on attachment 421569 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421569&action=review > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.mm:43 > +// clang-format off Did you mean to leave this in? > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/TextureMtl.mm:674 > + if(mState.getType() == gl::TextureType::Rectangle) > + { > + samplerDesc.normalizedCoordinates = NO; > + } > + else > + { > + samplerDesc.normalizedCoordinates = YES; > + } Use a ternary?
Dean Jackson
Comment 5 2021-02-25 15:28:20 PST
Committed r273516 (234591@main): <https://commits.webkit.org/234591@main>
Radar WebKit Bug Importer
Comment 6 2021-02-25 15:29:17 PST
<rdar://problem/74763493>
Note You need to log in before you can comment on or make changes to this bug.