Bug 222297

Summary:

Only files in WebCore/testing should be in WebCoreTestSupport

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

Tools / Tests

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, eric.carlson, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	none
Patch	none

Description Don Olmstead 2021-02-22 17:26:14 PST

Looks like in XCode and CMake there are issues here.

Comment 1 Don Olmstead 2021-02-22 17:31:15 PST Comment hidden (obsolete)

Created attachment 421272 [details]
WIP Patch

Comment 2 Don Olmstead 2021-02-22 17:43:19 PST Comment hidden (obsolete)

Created attachment 421276 [details]
WIP Patch

Trying to make Mac happy, has some non-unified build fixes with it

Comment 3 Don Olmstead 2021-02-22 18:15:40 PST Comment hidden (obsolete)

Created attachment 421279 [details]
WIP Patch

Comment 4 Don Olmstead 2021-02-22 21:12:15 PST

Created attachment 421284 [details]
Patch

Comment 5 EWS 2021-02-23 09:08:51 PST

Committed r273310: <https://commits.webkit.org/r273310>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421284 [details].

Comment 6 Radar WebKit Bug Importer 2021-02-23 09:09:14 PST

<rdar://problem/74644606>