Bug 222268
| Summary: | Videos do not work as sources for WebGL TexImage calls in SW fallback case in GPU Process | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | jer.noble, peng.liu6, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=222461 | ||
| Bug Depends on: | |||
| Bug Blocks: | 217211, 221838 | ||
Kimmo Kinnunen
Videos do not work as sources for WebGL TexImage calls in SW fallback case in GPU Process
void MediaPlayerPrivateRemote::paintCurrentFrameInContext(GraphicsContext&, const FloatRect&)
{
notImplemented();
}
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kimmo Kinnunen
Options to fix:
1) Implement readback in MediaPlayerPrivateRemote::paintCurrentFrameInContext
2) Move the ImageBuffer -> Texture logic from WebGLRenderingContextBase to GraphicsContextGL
2 is better long term
Radar WebKit Bug Importer
<rdar://problem/74706834>
Kimmo Kinnunen
For option 2:
The work is to convert
void WebGLRenderingContextBase::texImageImpl(TexImageFunctionID functionID, GCGLenum target, GCGLint level, GCGLenum internalformat, GCGLint xoffset, GCGLint yoffset, GCGLint zoffset, GCGLenum format, GCGLenum type, Image* image, GraphicsContextGL::DOMSource domSource, bool flipY, bool premultiplyAlpha, bool ignoreNativeImageAlphaPremultiplication, const IntRect& sourceImageRect, GCGLsizei depth, GCGLint unpackImageHeight)
to run on GPU process side resources.
Essentially converting Image* image to GPU process side resource.
However, that function _also_ needs to stay mostly working with Web process side resources, since some of the cases are such that probably no reasonable GPU process side resource exist.
Jer Noble
This was likely fixed by r273568, which will pull images across the process boundary when painting/texturing occurs there.
Peng Liu
*** This bug has been marked as a duplicate of bug 222461 ***