Bug 222265

Summary: [GTK] REGRESSION: Broken scrolling on element.io with async scrolling
Product: WebKit Reporter: Alice Mikhaylenko <alicem>
Component: WebKitGTKAssignee: Chris Lord <clord>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, bugs-noreply, cgarcia, clord, cmarcelo, ews-watchlist, fujii.hironori, kondapallykalyan, luiz, mcatanzaro, zdobersek
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Screen recording
none
Screenshot of a zoomed in page
none
Patch none

Alice Mikhaylenko
Reported 2021-02-22 03:58:27 PST
Created attachment 421176 [details] Screen recording See the recording. It's reproducible with http://svn.webkit.org/repository/webkit/trunk@273230. though it started a lot earlier. I'm pretty sure it can be reproduced elsewhere, and maybe even already has a bug filed, but can't find anything right now.
Attachments
Screen recording (5.37 MB, video/x-matroska)
2021-02-22 03:58 PST, Alice Mikhaylenko 		no flags
Details
Screenshot of a zoomed in page (181.66 KB, image/png)
2021-02-22 04:07 PST, Alice Mikhaylenko 		no flags
Details
Patch (2.01 KB, patch)
2021-05-21 03:48 PDT, Chris Lord 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alice Mikhaylenko
Comment 1 2021-02-22 04:07:40 PST
Created attachment 421178 [details] Screenshot of a zoomed in page Oh, I've missed a very important detail: it seems to only happen on HiDPI OR when the page is zoomed in via pinch zoom.
Alice Mikhaylenko
Comment 2 2021-05-16 12:36:14 PDT
Seems it also happens in the inspector, in the "All Layers" list.
Alice Mikhaylenko
Comment 3 2021-05-16 13:32:45 PDT
Found the cause. In `Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp`, ```cpp clipTransform.translate(options.offset.width() + m_state.boundsOrigin.x(), options.offset.height() + m_state.boundsOrigin.y()); ``` the origin coords should be multiplied by the scale factors (both page and device).
Chris Lord
Comment 4 2021-05-21 03:48:52 PDT
Created attachment 429280 [details] Patch
Alice Mikhaylenko
Comment 5 2021-05-21 03:56:19 PDT
I can confirm it works, both with scale factor and page zooming.
EWS
Comment 6 2021-05-21 05:23:48 PDT
Committed r277855 (237997@main): <https://commits.webkit.org/237997@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429280 [details].
Note You need to log in before you can comment on or make changes to this bug.