Summary: | [GTK] REGRESSION: Broken scrolling on element.io with async scrolling | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alice Mikhaylenko <alicem> | ||||||||
Component: | WebKitGTK | Assignee: | Chris Lord <clord> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | alex, bugs-noreply, cgarcia, clord, cmarcelo, ews-watchlist, Hironori.Fujii, kondapallykalyan, luiz, mcatanzaro, zdobersek | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Alice Mikhaylenko
2021-02-22 03:58:27 PST
Created attachment 421178 [details]
Screenshot of a zoomed in page
Oh, I've missed a very important detail: it seems to only happen on HiDPI OR when the page is zoomed in via pinch zoom.
Seems it also happens in the inspector, in the "All Layers" list. Found the cause. In `Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp`, ```cpp clipTransform.translate(options.offset.width() + m_state.boundsOrigin.x(), options.offset.height() + m_state.boundsOrigin.y()); ``` the origin coords should be multiplied by the scale factors (both page and device). Created attachment 429280 [details]
Patch
I can confirm it works, both with scale factor and page zooming. Committed r277855 (237997@main): <https://commits.webkit.org/237997@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429280 [details]. |