Summary: | [MSE] Media segment is incorrectly dropped when using negative timestampOffset | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> | ||||||||
Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jean-yves.avenard, jer.noble, menard, philipj, pnormand, sergio, vjaquez, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
URL: | https://jyavenard.github.io/htmltests/tests/mse_mp4/test_audiooffset.html | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=224067 | ||||||||||
Attachments: |
|
Description
Jean-Yves Avenard [:jya]
2021-02-21 20:33:16 PST
SourceBufferPrivateAVFObjC seems to pack the samples in block of 10 samples. So the first block of 10 samples is dropped. Created attachment 421288 [details]
Patch
Created attachment 421300 [details]
Patch
Comment on attachment 421300 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421300&action=review > Source/WebCore/ChangeLog:11 > + CoreMedia packs multiple audio frames together into a single CMSampleBuffer, this allows for faster processing and easier insertion into the track buffer tree. > + However, per mediasoure spec [1], a frame is to be dropped according to its start time and duration. So if only the beginning of the MediaSample was to be dropped, we would have incorrectly dropped the lot. Since there is a typo to fix, please wrap these overly long lines people won't need to scroll to read the ChangeLog. > Source/WebCore/ChangeLog:13 > + Audio splicing isn't done yet, but this gets us closeer to it. s/closeer/closer/ Created attachment 421477 [details]
Patch
Committed r273461: <https://commits.webkit.org/r273461> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421477 [details]. |