Bug 222259 – [WPE] 2 scroll snap padding tests are failing since enabled

• Component: WPE WebKit
• Status: RESOLVED FIXED

[Lauro Moura]

css3/scroll-snap/scroll-padding-mainframe-paging.html
css3/scroll-snap/scroll-padding-overflow-paging.html

Mainframe diff:

--- /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/css3/scroll-snap/scroll-padding-mainframe-paging-expected.txt
+++ /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/css3/scroll-snap/scroll-padding-mainframe-paging-actual.txt
@@ -1,11 +1,12 @@
-PASS paging moved body
-PASS paging moved padded body
-PASS document.scrollingElement.scrollTop is within 1 of 535.6837606837607
-PASS paging moved padded body
-PASS document.scrollingElement.scrollTop is within 1 of 535.6837606837607
-PASS paging moved padded body
-PASS document.scrollingElement.scrollTop is within 2 of 526.3675213675214
+FAIL paging moved body
+FAIL paging moved padded body
+PASS document.scrollingElement.scrollTop is within 1 of 0
+FAIL paging moved padded body
+PASS document.scrollingElement.scrollTop is within 1 of 0
+FAIL paging moved padded body
+PASS document.scrollingElement.scrollTop is within 2 of 0
 PASS successfullyParsed is true
+Some tests failed.
 
 TEST COMPLETE
 

Overflow diff:

--- /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/css3/scroll-snap/scroll-padding-overflow-paging-expected.txt
+++ /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/css3/scroll-snap/scroll-padding-overflow-paging-actual.txt
@@ -1,11 +1,12 @@
-PASS paging moved container
-PASS paging moved padded container
-PASS container.scrollTop is within 1 of 140
-PASS paging moved padded container
-PASS container.scrollTop is within 1 of 140
-PASS paging moved padded container
-PASS container.scrollTop is within 1 of 132
+FAIL paging moved container
+FAIL paging moved padded container
+PASS container.scrollTop is within 1 of 0
+FAIL paging moved padded container
+PASS container.scrollTop is within 1 of 0
+FAIL paging moved padded container
+PASS container.scrollTop is within 1 of 0
 PASS successfullyParsed is true
+Some tests failed.
 
 TEST COMPLETE

[Charlie Croom]

For additional context, I believe this may occur in STP too. Please compare the behavior of Safari to Firefox on https://codepen.io/comp615/pen/bGqbrEx

Click the "right" button a few times.

In Firefox (correct), on hitting C, D, E...the scroll is moved so that the selected item aligns with scroll-padding taken into account.

In Safari, (Wrong), D does not move the scroller (incorrect because it's behind the scroll-adding)...E also does not (wholly wrong because it's not even in the scroll frame)... and from there it moves the item alternatingly correctly

[Martin Robinson]

(In reply to Charlie Croom from comment #1)
> For additional context, I believe this may occur in STP too. Please compare
> the behavior of Safari to Firefox on https://codepen.io/comp615/pen/bGqbrEx
> 
> Click the "right" button a few times.
> 
> In Firefox (correct), on hitting C, D, E...the scroll is moved so that the
> selected item aligns with scroll-padding taken into account.
> 
> In Safari, (Wrong), D does not move the scroller (incorrect because it's
> behind the scroll-adding)...E also does not (wholly wrong because it's not
> even in the scroll frame)... and from there it moves the item alternatingly
> correctly

This issue is specifically tracking some failures on the WPE port (not Safari), but it looks like the issue you found is indeed a problem. I've opened a new bug for this here: https://bugs.webkit.org/show_bug.cgi?id=225387

[Vitaly Dyackhov]

Pull request: https://github.com/WebKit/WebKit/pull/6861

[EWS]

Test gardening commit 257071@main (1b6e6070bbb4): <https://commits.webkit.org/257071@main>

Reviewed commits have been landed. Closing PR #6861 and removing active labels.