Bug 222258

Summary: Add experimental support for CSS Color 5 color-mix()
Product: WebKit Reporter: Sam Weinig <sam>
Component: CSSAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, macpherson, menard, nimajneb0905, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=223457
Bug Depends on:    
Bug Blocks: 221873    
Attachments:
Description Flags
Patch none

Sam Weinig
Reported 2021-02-21 18:54:39 PST
Let's add experimental support for CSS Color 5 color-mix() - https://drafts.csswg.org/css-color-5/#color-mix. Because the spec doesn't seem quite finished, we should keep this behind an experimental feature flag for now.
Attachments
Patch (83.71 KB, patch)
2021-02-21 19:20 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2021-02-21 19:20:44 PST
Created attachment 421165 [details] Patch
Sam Weinig
Comment 2 2021-02-21 19:21:42 PST
There are a few FIXMEs in this to work out, and some additional test coverage, especially of hue mixing would be good as well.
Sam Weinig
Comment 3 2021-02-21 19:22:25 PST
I also wonder if we should move the color parsing code to it's own file at this point. It's getting quite involved.
EWS
Comment 4 2021-02-22 09:52:19 PST
Committed r273244: <https://commits.webkit.org/r273244> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421165 [details].
Radar WebKit Bug Importer
Comment 5 2021-02-22 09:53:14 PST
<rdar://problem/74600593>
Note You need to log in before you can comment on or make changes to this bug.