Summary: | REGRESSION (r272928): ASSERT NOT REACHED in WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||
Component: | New Bugs | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, ews-watchlist, japhet, mifenton, rniwa, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=221942 | ||||||||
Attachments: |
|
Description
Ryan Haddad
2021-02-19 20:20:04 PST
Test history suggests that this may have started after https://trac.webkit.org/changeset/272928/webkit I can reproduce this crash with the following command: ./Tools/Scripts/run-webkit-tests --ios-simulator --debug --no-build --no-retry editing/input/select-all-clear-input-method.html editing/input/set-value-on-input-and-delete.html --force It looks like the issue is that we're not canceling the composition in time when we're navigating to a new document. Created attachment 421250 [details]
Fixes the bug
Comment on attachment 421250 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=421250&action=review > Source/WebCore/ChangeLog:10 > + committing the composition even though the composition node had been removed from the docuemnt. Nit - docuemnt => document. Waiting for EWS... (In reply to Wenson Hsieh from comment #5) > Comment on attachment 421250 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=421250&action=review > > > Source/WebCore/ChangeLog:10 > > + committing the composition even though the composition node had been removed from the docuemnt. > > Nit - docuemnt => document. Fixed. Thanks for the review! Committed r273298 (234458@main): <https://commits.webkit.org/234458@main> |