Summary: | Support modules in service workers | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||||
Component: | Service Workers | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | beidson, saam, webkit-bug-importer, youennf, ysuzuki | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Yusuke Suzuki
2021-02-18 19:58:33 PST
Created attachment 421114 [details]
Patch
Created attachment 421130 [details]
Patch
Created attachment 421131 [details]
Patch
Created attachment 421132 [details]
Patch
Comment on attachment 421132 [details]
Patch
LGTM. Should we add some of our own tests too that aren’t imported?
(In reply to Saam Barati from comment #6) > Comment on attachment 421132 [details] > Patch > > LGTM. Should we add some of our own tests too that aren’t imported? I think, for now, imported tests cover the things we would like to check. So, I will add tests if issue is found. Committed r273224 (234410@main): <https://commits.webkit.org/234410@main> |