Bug 22212 – [Transforms] redrawing turds when transforming element with abs. pos child

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

The testcase shows a redraw issue when transforming something with an absolute position child.

[Simon Fraser (smfr)]

Created attachment 25101 [details]
Testcase

[Simon Fraser (smfr)]

The issue here is that RenderObject::repaintAfterLayoutIfNeeded() falls into the "just redraw the deltas" codepath when redrawing the abs. positioned gray bar.

[Simon Fraser (smfr)]

Created attachment 25109 [details]
Patch, testcase, changelog

Comment on attachment 25109 [details]
Patch, testcase, changelog

> +     #box {
> +        position: relative;
> +         margin: 50px;
> +         width: 200px;
> +         height: 200px;
> +         border: 2px solid black;
> +         -webkit-transform: rotate(0deg);
> +
> +     }

Tiny indentation problem here.

> +        Finally, fix a bug in RenderBox::localToAbsoluteQuad() which was getting
> +        borderTopExtra() from the object, rather than its container (as localToAbsolute()
> +        does).

Do you have a test for this?

r=me

[Simon Fraser (smfr)]

> Do you have a test for this?

It was exposed by LayoutTests/fast/dynamic/subtree-table-cell-height.html, so is covered.

[Simon Fraser (smfr)]

Committed r38353
	M	WebCore/rendering/RenderFlexibleBox.cpp
	M	WebCore/rendering/RenderObject.cpp
	M	WebCore/rendering/RenderSVGContainer.cpp
	M	WebCore/rendering/RenderSVGViewportContainer.cpp
	M	WebCore/rendering/RenderObject.h
	M	WebCore/rendering/RenderLayer.cpp
	M	WebCore/rendering/RenderForeignObject.cpp
	M	WebCore/rendering/RenderPath.cpp
	M	WebCore/rendering/RenderBox.cpp
	M	WebCore/rendering/RenderBlock.cpp
	M	WebCore/rendering/RenderTable.cpp
	M	WebCore/rendering/RenderSVGImage.cpp
	M	WebCore/rendering/RenderSVGText.cpp
	M	WebCore/rendering/RenderReplaced.cpp
	M	WebCore/rendering/RenderSVGRoot.cpp
	M	WebCore/ChangeLog
	A	LayoutTests/platform/mac/fast/repaint/transform-absolute-child-expected.png
	A	LayoutTests/platform/mac/fast/repaint/transform-absolute-child-expected.txt
	A	LayoutTests/platform/mac/fast/repaint/transform-absolute-child-expected.checksum
	M	LayoutTests/ChangeLog
	A	LayoutTests/fast/repaint/transform-absolute-child.html
r38353 = d12c84b463bdb934ab22f7931948b30951f4e310 (trunk)