Bug 222057

Summary: Web Inspector: Truncate long node display names in Grid Overlay list
Product: WebKit Reporter: Razvan Caliman <rcaliman>
Component: Web InspectorAssignee: Razvan Caliman <rcaliman>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Screenshot of grid overlay list with long node display names
none
Reduced sample case with truncation working
none
=WIP
none
Patch
none
Patch
none
Patch
none
Patch none

Razvan Caliman
Reported 2021-02-17 11:12:42 PST
Created attachment 420676 [details] Screenshot of grid overlay list with long node display names See attached screenshot. When node display names are too long (ex: long CSS class name), color swatches are pushed off screen.
Attachments
Screenshot of grid overlay list with long node display names (125.23 KB, image/jpeg)
2021-02-17 11:12 PST, Razvan Caliman 		no flags
Details
Reduced sample case with truncation working (1.75 KB, text/html)
2021-02-17 11:15 PST, Razvan Caliman 		no flags
Details
=WIP (830 bytes, patch)
2021-02-17 11:19 PST, Razvan Caliman 		no flags
DetailsFormatted DiffDiff
Patch (5.64 KB, patch)
2021-02-18 08:22 PST, Razvan Caliman 		no flags
DetailsFormatted DiffDiff
Patch (5.64 KB, patch)
2021-02-18 11:22 PST, Razvan Caliman 		no flags
DetailsFormatted DiffDiff
Patch (5.59 KB, patch)
2021-02-19 07:46 PST, Razvan Caliman 		no flags
DetailsFormatted DiffDiff
Patch (5.58 KB, patch)
2021-02-19 09:43 PST, Razvan Caliman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Razvan Caliman
Comment 1 2021-02-17 11:15:12 PST
Created attachment 420678 [details] Reduced sample case with truncation working Basic sample using the same markup from Web Inspector but with applied minimal CSS to achieve truncation.
Razvan Caliman
Comment 2 2021-02-17 11:19:07 PST
Created attachment 420681 [details] =WIP WIP perplexigly not working in Web Inspector UI despite using the same CSS as the basic sample attached
Razvan Caliman
Comment 3 2021-02-18 08:22:21 PST
Created attachment 420829 [details] Patch
Blaze Burg
Comment 4 2021-02-18 09:35:29 PST
Comment on attachment 420829 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420829&action=review r=me with class name fix > Source/WebInspectorUI/UserInterface/Views/CSSGridSection.css:38 > +.css-grid-section .node-overlay-list__item-container { Please replace __ with -, we don't use underscores in class names in this codebase.
Razvan Caliman
Comment 5 2021-02-18 11:22:46 PST
Created attachment 420857 [details] Patch Carry over R+
EWS
Comment 6 2021-02-18 12:38:38 PST
The 'validate-changelog' command is currently deprecated due to believed non-use; if it forms part of your workflow, please comment on https://bugs.webkit.org/show_bug.cgi?id=221991 and please include the command you ran, even if others have already mentioned it ChangeLog entry in Source/WebInspectorUI/ChangeLog contains OOPS!.
Razvan Caliman
Comment 7 2021-02-19 07:46:02 PST
Created attachment 420965 [details] Patch Carry over R+; retry EWS bots with rebased patch
EWS
Comment 8 2021-02-19 09:39:26 PST
ChangeLog entry in Source/WebInspectorUI/ChangeLog contains OOPS!.
Razvan Caliman
Comment 9 2021-02-19 09:43:14 PST
Created attachment 420983 [details] Patch Carry over R+; update changelog with name of reviewer
EWS
Comment 10 2021-02-19 10:53:46 PST
Committed r273148: <https://commits.webkit.org/r273148> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420983 [details].
Radar WebKit Bug Importer
Comment 11 2021-02-19 10:54:17 PST
<rdar://problem/74529013>
Note You need to log in before you can comment on or make changes to this bug.