Bug 222048

Summary: Use element fullscreen for video on some configurations
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
sam: review-, ews-feeder: commit-queue-
Updated patch none

Description Dean Jackson 2021-02-17 10:15:36 PST 
Enable element fullscreen for video on some configurations
Comment 1 Radar WebKit Bug Importer 2021-02-17 10:22:39 PST 
<rdar://problem/74439214>
Comment 2 Dean Jackson 2021-02-17 10:24:57 PST 
Created attachment 420664 [details]
Patch
Comment 3 Sam Weinig 2021-02-17 10:26:42 PST 
Comment on attachment 420664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420664&action=review

> Source/WTF/wtf/PlatformEnableCocoa.h:549
> +#if !defined(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) && (PLATFORM(MAC) && HAVE(UIKIT_WEBKIT_INTERNALS)

This should be 

#if !defined(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) && (PLATFORM(MAC) || HAVE(UIKIT_WEBKIT_INTERNALS))
Comment 4 Dean Jackson 2021-02-17 10:27:13 PST 
Created attachment 420665 [details]
Updated patch
Comment 5 EWS 2021-02-17 12:32:03 PST 
Committed r273020: <https://commits.webkit.org/r273020>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420665 [details].