Bug 222024

Summary: Import CSS @counter-style WPTs
Product: WebKit Reporter: Tyler Wilcock <twilco.o>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, ews-watchlist, fujii.hironori, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Attachments
Patch (908.05 KB, patch)
2021-02-16 20:15 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (910.74 KB, patch)
2021-02-17 13:14 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (911.03 KB, patch)
2021-02-17 13:33 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (911.19 KB, patch)
2021-02-17 20:10 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Tyler Wilcock
Comment 1 2021-02-16 20:15:01 PST
Created attachment 420589 [details] Patch
Tyler Wilcock
Comment 2 2021-02-17 13:14:00 PST
Created attachment 420700 [details] Patch
Tyler Wilcock
Comment 3 2021-02-17 13:33:59 PST
Created attachment 420706 [details] Patch
EWS
Comment 4 2021-02-17 20:05:24 PST
Tools/Scripts/svn-apply failed to apply attachment 420706 [details] to trunk. Please resolve the conflicts and upload a new patch.
Tyler Wilcock
Comment 5 2021-02-17 20:10:38 PST
Created attachment 420789 [details] Patch
EWS
Comment 6 2021-02-17 22:42:39 PST
Found 1 new test failure: media/modern-media-controls/volume-support/volume-support-drag.html
Tyler Wilcock
Comment 7 2021-02-17 23:01:04 PST
The failure encountered by the commit build seems like a flake? I don't think importing these tests would cause that. I'd like to try cq? again if someone wouldn't mind setting it for me.
Fujii Hironori
Comment 8 2021-02-17 23:09:40 PST
Comment on attachment 420789 [details] Patch Clearing flags on attachment: 420789 Committed r273065 (234263@main): <https://commits.webkit.org/234263@main>
Fujii Hironori
Comment 9 2021-02-17 23:09:44 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2021-02-17 23:10:18 PST
<rdar://problem/74466355>
Tyler Wilcock
Comment 11 2021-02-17 23:12:14 PST
Oops, I assumed the commit step test failure blocked the patch from landing. Thanks Fujii!
Note You need to log in before you can comment on or make changes to this bug.