Bug 222024

Summary: Import CSS @counter-style WPTs
Product: WebKit Reporter: Tyler Wilcock <twilco.o>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, ews-watchlist, Hironori.Fujii, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Comment 1 Tyler Wilcock 2021-02-16 20:15:01 PST 
Created attachment 420589 [details]
Patch
Comment 2 Tyler Wilcock 2021-02-17 13:14:00 PST 
Created attachment 420700 [details]
Patch
Comment 3 Tyler Wilcock 2021-02-17 13:33:59 PST 
Created attachment 420706 [details]
Patch
Comment 4 EWS 2021-02-17 20:05:24 PST 
Tools/Scripts/svn-apply failed to apply attachment 420706 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 5 Tyler Wilcock 2021-02-17 20:10:38 PST 
Created attachment 420789 [details]
Patch
Comment 6 EWS 2021-02-17 22:42:39 PST 
Found 1 new test failure: media/modern-media-controls/volume-support/volume-support-drag.html
Comment 7 Tyler Wilcock 2021-02-17 23:01:04 PST 
The failure encountered by the commit build seems like a flake?  I don't think importing these tests would cause that.  I'd like to try cq? again if someone wouldn't mind setting it for me.
Comment 8 Fujii Hironori 2021-02-17 23:09:40 PST 
Comment on attachment 420789 [details]
Patch

Clearing flags on attachment: 420789

Committed r273065 (234263@main): <https://commits.webkit.org/234263@main>
Comment 9 Fujii Hironori 2021-02-17 23:09:44 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2021-02-17 23:10:18 PST 
<rdar://problem/74466355>
Comment 11 Tyler Wilcock 2021-02-17 23:12:14 PST 
Oops, I assumed the commit step test failure blocked the patch from landing.  Thanks Fujii!