Bug 222015

Summary:

[iOS][FCR] Enable the new appearance by default

Product:

WebKit

Reporter:

Aditya Keerthi <akeerthi>

Component:

Forms

Assignee:

Aditya Keerthi <akeerthi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, macpherson, menard, philipj, sergio, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP	none
Patch	none
Patch	none
Tests found using script	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none

Aditya Keerthi

Reported 2021-02-16 17:58:45 PST

...

Attachments
WIP (1.28 KB, patch) 2021-02-16 18:02 PST, Aditya Keerthi	no flags	Details Formatted Diff Diff
Patch (61.60 KB, patch) 2021-02-17 10:45 PST, Aditya Keerthi	no flags	Details Formatted Diff Diff
Patch (205.07 KB, patch) 2021-02-17 14:53 PST, Aditya Keerthi	no flags	Details Formatted Diff Diff
Tests found using script (1.22 MB, patch) 2021-02-17 16:32 PST, Aditya Keerthi	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (1.33 MB, patch) 2021-02-17 21:37 PST, Aditya Keerthi	no flags	Details Formatted Diff Diff
Patch (1.34 MB, patch) 2021-02-18 13:12 PST, Aditya Keerthi	no flags	Details Formatted Diff Diff
Patch (1.34 MB, patch) 2021-02-18 22:11 PST, Aditya Keerthi	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Aditya Keerthi

Comment 1 2021-02-16 17:58:58 PST

<rdar://problem/74415537>

Aditya Keerthi

Comment 2 2021-02-16 18:02:56 PST

Created attachment 420574 [details] WIP

Aditya Keerthi

Comment 3 2021-02-17 10:45:20 PST

Created attachment 420669 [details] Patch

Aditya Keerthi

Comment 4 2021-02-17 14:53:31 PST

Created attachment 420725 [details] Patch

Aditya Keerthi

Comment 5 2021-02-17 16:32:24 PST

Created attachment 420758 [details] Tests found using script

Aditya Keerthi

Comment 6 2021-02-17 21:37:25 PST

Created attachment 420795 [details] Patch

Aditya Keerthi

Comment 7 2021-02-18 13:12:49 PST

Created attachment 420865 [details] Patch

Aditya Keerthi

Comment 8 2021-02-18 22:11:06 PST

Created attachment 420922 [details] Patch

Wenson Hsieh

Comment 9 2021-02-19 11:07:23 PST

Comment on attachment 420922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420922&action=review > LayoutTests/fast/forms/ios/select-picker-change-and-focus-another-select.html:1 > +<!DOCTYPE html>  While some of these tests are no longer relevant, we should file followup bugs to make some of these tests work using the new (refreshed) UI. This seems like one that might potentially still be applicable? (Maybe only with a hardware keyboard attached though) > LayoutTests/platform/ipad/fast/forms/choose-select-option.html:1 > +<!DOCTYPE html>  This seems like another test that could (feasibly) be adapted to the refreshed select UI.

Aditya Keerthi

Comment 10 2021-02-19 11:25:09 PST

(In reply to Wenson Hsieh from comment #9) > Comment on attachment 420922 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=420922&action=review > > > LayoutTests/fast/forms/ios/select-picker-change-and-focus-another-select.html:1 > > +<!DOCTYPE html>  > > While some of these tests are no longer relevant, we should file followup > bugs to make some of these tests work using the new (refreshed) UI. This > seems like one that might potentially still be applicable? (Maybe only with > a hardware keyboard attached though) This one was actually only relevant on iPhones, where it was possible to tap a select element while the picker was displayed for another element. It was never relevant on iPads since the tap would just dismiss the presented popover and an additional tap would be required to focus the other element. However, now that we present a modal view / context menu to choose options, it's no longer possible to immediately tap a select element while choosing options for another, since the first tap would dismiss the modal view / context menu. But I will take a look and see if there are other tests that can be adapted. > > LayoutTests/platform/ipad/fast/forms/choose-select-option.html:1 > > +<!DOCTYPE html>  > > This seems like another test that could (feasibly) be adapted to the > refreshed select UI. This test has already been adapted to the new UI – see LayoutTests/fast/forms/ios/form-control-refresh/select/choose-select-option.html.

EWS

Comment 11 2021-02-19 11:44:10 PST

Committed r273154: <https://commits.webkit.org/r273154> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420922 [details].

Note You need to log in before you can comment on or make changes to this bug.