Bug 222002

Summary:

[Payment Request] add an `object data` to `PaymentDetailsBase` so that data specific to Apple Pay can be provided

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Platform

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, aestes, annulen, bdakin, cdumez, eoconnor, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, japhet, kondapallykalyan, megan_gardner, ryuan.choi, sergio, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

221970

Bug Blocks:

222128, 222298, 223621

Attachments:

Description	Flags
Patch	hi: commit-queue-
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none

Devin Rousso

Reported 2021-02-16 14:51:44 PST

Attachments
Patch (184.30 KB, patch) 2021-02-16 15:23 PST, Devin Rousso	hi: commit-queue-	Details Formatted Diff Diff
Patch (185.73 KB, patch) 2021-02-17 21:47 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (189.47 KB, patch) 2021-02-18 18:01 PST, Devin Rousso	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (189.47 KB, patch) 2021-02-18 18:13 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (190.03 KB, patch) 2021-02-18 19:23 PST, Devin Rousso	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (190.07 KB, patch) 2021-02-18 21:43 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2021-02-16 14:52:30 PST

<rdar://problem/72319946>

Devin Rousso

Comment 2 2021-02-16 15:23:43 PST

Created attachment 420548 [details] Patch

Devin Rousso

Comment 3 2021-02-17 21:47:56 PST

Created attachment 420796 [details] Patch

Devin Rousso

Comment 4 2021-02-18 18:01:48 PST

Created attachment 420892 [details] Patch

Devin Rousso

Comment 5 2021-02-18 18:13:57 PST

Created attachment 420894 [details] Patch

Tim Horton

Comment 6 2021-02-18 19:01:54 PST

Comment on attachment 420894 [details] Patch Same as last time, would be good to get an Andy review post-hoc, but the mechanics seem fine and no glaring horrors.

Devin Rousso

Comment 7 2021-02-18 19:23:38 PST

Created attachment 420905 [details] Patch

Devin Rousso

Comment 8 2021-02-18 21:43:46 PST

Created attachment 420920 [details] Patch

EWS

Comment 9 2021-02-18 22:02:25 PST Comment hidden (obsolete)

Found 30 new test failures: compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html, css3/calc/transforms-translate.html, http/tests/inspector/paymentrequest/payment-request-internal-properties.https.html, http/tests/paymentrequest/page-cache-closed-payment-request.https.html, http/tests/paymentrequest/page-cache-completed-payment-response.https.html, http/tests/paymentrequest/page-cache-created-payment-request.https.html, http/tests/paymentrequest/page-cache-created-payment-response.https.html, http/tests/paymentrequest/page-cache-interactive-payment-request.https.html, http/tests/paymentrequest/page-cache-retried-payment-response.https.html, http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html ...

EWS

Comment 10 2021-02-19 09:38:43 PST

Committed r273143: <https://commits.webkit.org/r273143> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420920 [details].

Note You need to log in before you can comment on or make changes to this bug.