Summary: | [Payment Request] add an `object data` to `PaymentDetailsBase` so that data specific to Apple Pay can be provided | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||||||
Component: | Platform | Assignee: | Devin Rousso <hi> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | achristensen, aestes, annulen, bdakin, cdumez, eoconnor, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, japhet, kondapallykalyan, megan_gardner, ryuan.choi, sergio, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | 221970 | ||||||||||||||||
Bug Blocks: | 222128, 222298, 223621 | ||||||||||||||||
Attachments: |
|
Description
Devin Rousso
2021-02-16 14:51:44 PST
Created attachment 420548 [details]
Patch
Created attachment 420796 [details]
Patch
Created attachment 420892 [details]
Patch
Created attachment 420894 [details]
Patch
Comment on attachment 420894 [details]
Patch
Same as last time, would be good to get an Andy review post-hoc, but the mechanics seem fine and no glaring horrors.
Created attachment 420905 [details]
Patch
Created attachment 420920 [details]
Patch
Found 30 new test failures: compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html, css3/calc/transforms-translate.html, http/tests/inspector/paymentrequest/payment-request-internal-properties.https.html, http/tests/paymentrequest/page-cache-closed-payment-request.https.html, http/tests/paymentrequest/page-cache-completed-payment-response.https.html, http/tests/paymentrequest/page-cache-created-payment-request.https.html, http/tests/paymentrequest/page-cache-created-payment-response.https.html, http/tests/paymentrequest/page-cache-interactive-payment-request.https.html, http/tests/paymentrequest/page-cache-retried-payment-response.https.html, http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html ... Committed r273143: <https://commits.webkit.org/r273143> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420920 [details]. |