Bug 221948 – REGRESSION (r266695): Unable to scroll the menu in 北京114预约挂号 official account - WeChat

• Component: New Bugs
• Status: RESOLVED FIXED

[Myles C. Maxfield]

REGRESSION (r266695): Unable to scroll the menu in 北京114预约挂号 official account - WeChat

[Myles C. Maxfield]

Created attachment 420425 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/71661277>

[Sergio Villar Senin]

Comment on attachment 420425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420425&action=review

Discussed this in private with Myles. Looks good to me, but I'd let Apple folks to give the final r+.

> Source/WebCore/style/StyleAdjuster.cpp:610
> +    if (m_document.quirks().needsWeChatScrollingQuirk()) {

Would it make sense to wrap it in #if PLATFORM(IOS_FAMILY) ?

That would imply also wrapping needsWeChatScrollingQuirk() isWeChat()

[Simon Fraser (smfr)]

Comment on attachment 420425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420425&action=review

> Source/WebCore/style/StyleAdjuster.cpp:612
> +        static MainThreadNeverDestroyed<const AtomString> attribute1("data-v-f9dfb3e2", AtomString::ConstructFromLiteral);
> +        static MainThreadNeverDestroyed<const AtomString> attribute2("data-v-33719130", AtomString::ConstructFromLiteral);

It seems very likely that they could re-deploy content and these identifiers would change.

[Simon Fraser (smfr)]

Comment on attachment 420425 [details]
Patch

Also I think we should disable this with a linked-on-or-faster check.

[Myles C. Maxfield]

(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 420425 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=420425&action=review
> 
> > Source/WebCore/style/StyleAdjuster.cpp:612
> > +        static MainThreadNeverDestroyed<const AtomString> attribute1("data-v-f9dfb3e2", AtomString::ConstructFromLiteral);
> > +        static MainThreadNeverDestroyed<const AtomString> attribute2("data-v-33719130", AtomString::ConstructFromLiteral);
> 
> It seems very likely that they could re-deploy content and these identifiers
> would change.

I was trying to be as specific as possible, because whatever condition is here will be applied across all of WeChat (including all of its mini-apps and everything). Do you think I was overly conservative? Do you have a suggestion for a better way to isolate this case without being too general?

[Simon Fraser (smfr)]

Are there other nodes that match the style and "tree-select" and "v-tree-select" checks that don't want the fix? Presumably if this particular page is broken, there may be other pages that are also broken, so a slightly more permissible check might better?

[Myles C. Maxfield]

Comment on attachment 420425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420425&action=review

>> Source/WebCore/style/StyleAdjuster.cpp:610
>> +    if (m_document.quirks().needsWeChatScrollingQuirk()) {
> 
> Would it make sense to wrap it in #if PLATFORM(IOS_FAMILY) ?
> 
> That would imply also wrapping needsWeChatScrollingQuirk() isWeChat()

I think not, because needsWeChatScrollingQuirk() already has the check inside it.

[Myles C. Maxfield]

Created attachment 420568 [details]
Patch

[Myles C. Maxfield]

Created attachment 420572 [details]
Patch

[Myles C. Maxfield]

Created attachment 420575 [details]
Patch

[EWS]

Committed r272977: <https://commits.webkit.org/r272977>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420575 [details].