Bug 221936

Summary: [ARM64] Change break instruction comment to indicate possible security failure
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, mark.lam, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Michael Saboff
Reported 2021-02-15 16:34:50 PST
On ARM64, we can use a non-zero immediate value to indicate a possible security failure.
Attachments
Patch (6.02 KB, patch)
2021-02-15 16:39 PST, Michael Saboff 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2021-02-15 16:35:18 PST
<rdar://74154659>
Michael Saboff
Comment 2 2021-02-15 16:39:27 PST
Created attachment 420394 [details] Patch
Mark Lam
Comment 3 2021-02-15 16:43:22 PST
Comment on attachment 420394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420394&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + using the same value the compiler emits. nit: I would say "C++ compiler" to be more explicit especially since there are so many compilers in our domain.
Michael Saboff
Comment 4 2021-02-15 17:49:02 PST
(In reply to Mark Lam from comment #3) > > Source/JavaScriptCore/ChangeLog:9 > > + using the same value the compiler emits. > > nit: I would say "C++ compiler" to be more explicit especially since there > are so many compilers in our domain. Done.
Michael Saboff
Comment 5 2021-02-15 17:51:53 PST
Committed r272892 (234125@main): <https://commits.webkit.org/234125@main>
Note You need to log in before you can comment on or make changes to this bug.