Bug 221935

Summary: [ macOS ] media/webaudio-background-playback.html is a flakey text failure
Product: WebKit Reporter: Robert Jenner <jenner>
Component: New BugsAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, pnormand, sergio, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Update TestExpectations
none
Patch
none
Patch
none
Patch none

Description Robert Jenner 2021-02-15 16:32:43 PST
media/webaudio-background-playback.html


is a flakey text failure on macOS.

HISTORY URL:
https://results.webkit.org/?suite=layout-tests&test=media%2Fwebaudio-background-playback.html

DIFF URL:
https://build.webkit.org/results/Apple-BigSur-Release-WK2-Tests/r272883%20(213)/media/webaudio-background-playback-pretty-diff.html

DIFF TEXT:
-PASS Ensure WebAudio stops playing in the background when the 'BackgroundProcessPlaybackRestricted' restriction is set
+FAIL Ensure WebAudio stops playing in the background when the 'BackgroundProcessPlaybackRestricted' restriction is set assert_true: audio resumed playing in the foreground expected true got false
Comment 1 Radar WebKit Bug Importer 2021-02-15 16:33:00 PST
<rdar://problem/74370844>
Comment 2 Robert Jenner 2021-02-16 10:03:54 PST
Created attachment 420486 [details]
Patch
Comment 3 Chris Dumez 2021-02-16 10:06:13 PST
Comment on attachment 420486 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420486&action=review

> LayoutTests/ChangeLog:10
> +2021-02-16  Robert Jenner  <jenner@apple.com>

Too many changelogs.
Comment 4 Robert Jenner 2021-02-17 15:27:01 PST
Created attachment 420733 [details]
Update TestExpectations
Comment 5 Truitt Savell 2021-02-17 15:31:37 PST
Comment on attachment 420733 [details]
Update TestExpectations

Clearing flags on attachment: 420733

Committed r273038 (234239@main): <https://commits.webkit.org/234239@main>
Comment 6 Philippe Normand 2021-04-03 04:17:56 PDT
Created attachment 425090 [details]
Patch
Comment 7 Philippe Normand 2021-04-03 04:19:37 PDT
Created attachment 425091 [details]
Patch
Comment 8 Eric Carlson 2021-04-05 09:59:46 PDT
Comment on attachment 425091 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425091&action=review

> LayoutTests/ChangeLog:9
> +        The test was flaky because it was checking the destination had processed new buffers

s/checking the destination/checking if the destination/
Comment 9 Philippe Normand 2021-04-05 10:18:04 PDT
Created attachment 425167 [details]
Patch
Comment 10 EWS 2021-04-05 18:13:58 PDT
Committed r275468: <https://commits.webkit.org/r275468>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425167 [details].