Bug 221931

Summary: Web Animations JS API does not support "inherit" CSS values for keyframes
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, dino, esprehn+autocc, ews-watchlist, glenn, graouts, koivisto, kondapallykalyan, pdr, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 221926    
Bug Blocks:    
Attachments:
Description Flags
Patch for EWS
none
Patch koivisto: review+, ews-feeder: commit-queue-

Antoine Quint
Reported 2021-02-15 15:04:07 PST
Web Animations JS API does not support "inherit" CSS values for keyframes
Attachments
Patch for EWS (233.67 KB, patch)
2021-02-15 15:05 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (224.65 KB, patch)
2021-02-16 03:45 PST, Antoine Quint 		koivisto: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2021-02-15 15:05:00 PST
Created attachment 420384 [details] Patch for EWS
Antoine Quint
Comment 2 2021-02-15 15:06:25 PST
Supporting this should allow for at least 350 WPT tests to progress.
Antoine Quint
Comment 3 2021-02-15 15:08:32 PST
This will be fixed by ensuring we pass the parent style down to Style::Resolver::styleForKeyframe() throughout the animation resolution code. As such this is blocked by bug 221926.
Antoine Quint
Comment 4 2021-02-16 03:45:26 PST
Created attachment 420445 [details] Patch
Antti Koivisto
Comment 5 2021-02-16 03:55:26 PST
Comment on attachment 420445 [details] Patch nice!
EWS
Comment 6 2021-02-16 05:36:55 PST
commit-queue failed to commit attachment 420445 [details] to WebKit repository. To retry, please set cq+ flag again.
Antoine Quint
Comment 7 2021-02-16 07:20:54 PST
Committed r272904 (234137@main): <https://commits.webkit.org/234137@main>
Radar WebKit Bug Importer
Comment 8 2021-02-16 07:21:13 PST
<rdar://problem/74390501>
Note You need to log in before you can comment on or make changes to this bug.