Bug 221929

Summary: Clean up WKWebView media API
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: WebKit Misc.Assignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, peng.liu6, philipj, sergio, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225696
Attachments:
Description Flags
Patch
none
Patch for landing none

Kate Cheney
Reported 2021-02-15 14:48:50 PST
We should make some changes to some new WKWebView media API after the review process
Attachments
Patch (26.03 KB, patch)
2021-02-15 16:02 PST, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch for landing (25.05 KB, patch)
2021-02-16 11:53 PST, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kate Cheney
Comment 1 2021-02-15 14:56:04 PST
<rdar://problem/73460121>
Kate Cheney
Comment 2 2021-02-15 16:02:05 PST
Created attachment 420389 [details] Patch
youenn fablet
Comment 3 2021-02-15 23:16:42 PST
Comment on attachment 420389 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420389&action=review > Source/WebKit/ChangeLog:14 > + better Swift imports. Out of curiosity, what does it give in terms of Swift? For ObjC, it gives pretty long names.
Kate Cheney
Comment 4 2021-02-16 11:53:11 PST
Created attachment 420514 [details] Patch for landing
Kate Cheney
Comment 5 2021-02-16 11:53:48 PST
(In reply to youenn fablet from comment #3) > Comment on attachment 420389 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=420389&action=review > > > Source/WebKit/ChangeLog:14 > > + better Swift imports. > > Out of curiosity, what does it give in terms of Swift? > For ObjC, it gives pretty long names. It will give: func pauseAllMediaPlayback(completionHandler: (() -> Void)? instead of func pauseAllMediaPlayback((() -> Void)?)
EWS
Comment 6 2021-02-16 12:59:47 PST
Committed r272923: <https://commits.webkit.org/r272923> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420514 [details].
Note You need to log in before you can comment on or make changes to this bug.