Bug 221916 – MediaRecorder.stop() does not work correctly when recording has been paused.

• Component: WebRTC
• Status: RESOLVED FIXED

[David Mannion]

MediaRecorder::stopRecordingInternal() is not setting the state = RecordingState::Inactive when the current state == RecordingState::Paused.  The current code:

316	    if (state() != RecordingState::Recording) {
317	        completionHandler();
318	        return;
319	    }

should probably be:

316	    if (state() === RecordingState::Inactive) {
317	        completionHandler();
318	        return;
319	    }


The problem can be reproduced using these steps:
1) Start Recording
2) Pause Recording
3) Stop Recording
4) Start Recording

Actual result: After step 3, the status is still paused. Also, an exception is thrown and the browser reloads when trying to re-start recording.
Expected result: After step 3, the status should be inactive.  Also recording should re-start without error.

[Radar WebKit Bug Importer]

<rdar://problem/74366154>

[youenn fablet]

> Actual result: After step 3, the status is still paused. Also, an exception
> is thrown and the browser reloads when trying to re-start recording.
When you say the browser reloads, does it mean there is a crash and the page reloads?

[youenn fablet]

Created attachment 420428 [details]
Patch

[youenn fablet]

Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/27638

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[EWS]

Committed r272911: <https://commits.webkit.org/r272911>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420428 [details].

[David Mannion]

(In reply to youenn fablet from comment #2)
> > Actual result: After step 3, the status is still paused. Also, an exception
> > is thrown and the browser reloads when trying to re-start recording.
> When you say the browser reloads, does it mean there is a crash and the page
> reloads?

My mistake.  It crashes if you call resume().  Calling start() throws an exception.