Bug 221905

Summary: [macOS] Close XPC connections before entering sandbox
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Per Arne Vollan
Reported 2021-02-15 09:39:44 PST
XPC connections that are now allowed in the sandbox should be closed before entering the sandbox.
Attachments
Patch (3.04 KB, patch)
2021-02-15 11:32 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2021-02-15 09:41:51 PST
<rdar://70359582>
Per Arne Vollan
Comment 2 2021-02-15 11:32:31 PST
Created attachment 420342 [details] Patch
Brent Fulgham
Comment 3 2021-02-15 13:56:14 PST
Comment on attachment 420342 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420342&action=review r=me > Source/WebKit/ChangeLog:9 > + XPC connections that are now allowed in the sandbox should be closed before entering the sandbox. Is it possible to do something like this on iOS? Or do we already do so?
Per Arne Vollan
Comment 4 2021-02-15 19:55:09 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 420342 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=420342&action=review > > r=me > > > Source/WebKit/ChangeLog:9 > > + XPC connections that are now allowed in the sandbox should be closed before entering the sandbox. > > Is it possible to do something like this on iOS? Or do we already do so? I don’t believe this is needed on iOS, since the specific connection we are closing here, only exists on macOS. Thanks for reviewing!
EWS
Comment 5 2021-02-15 20:29:42 PST
Committed r272896: <https://commits.webkit.org/r272896> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420342 [details].
Note You need to log in before you can comment on or make changes to this bug.