Bug 221872

Summary: [JSC] PropertySlot should allow passing custom setters
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: JavaScriptCoreAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Minor CC: annulen, clopez, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sam, sergio, tzagallo, webkit-bug-importer, youennf, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://github.com/web-platform-tests/wpt/pull/28031
https://bugs.webkit.org/show_bug.cgi?id=238180
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch ysuzuki: review+

Alexey Shvayka
Reported 2021-02-13 18:24:25 PST
[JSC] PropertySlot should allow passing custom setters
Attachments
Patch (83.44 KB, patch)
2021-02-13 18:33 PST, Alexey Shvayka 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (84.53 KB, patch)
2021-02-13 19:09 PST, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (84.56 KB, patch)
2021-02-13 19:58 PST, Alexey Shvayka 		ysuzuki: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2021-02-13 18:33:47 PST
Created attachment 420230 [details] Patch
EWS Watchlist
Comment 2 2021-02-13 18:34:45 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Alexey Shvayka
Comment 3 2021-02-13 19:09:50 PST
Created attachment 420231 [details] Patch Adjust JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS.
Alexey Shvayka
Comment 4 2021-02-13 19:58:20 PST
Created attachment 420233 [details] Patch Set PropertyAttribute::Accessor.
Yusuke Suzuki
Comment 5 2021-02-14 02:04:04 PST
Comment on attachment 420233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420233&action=review r=me > Source/JavaScriptCore/runtime/VM.cpp:-391 > - , customGetterSetterFunctionMap(*this) Nice > Source/JavaScriptCore/runtime/VM.cpp:1485 > +DYNAMIC_ISO_SUBSPACE_DEFINE_MEMBER_SLOW(customGetterFunctionSpace, cellHeapCellType.get(), JSCustomGetterFunction) // Hash:0x18091000 This hash (// Hash:0x18091000) should be changed. So let's drop it.
Alexey Shvayka
Comment 6 2021-02-15 15:11:07 PST
Committed r272885 (234118@main): <https://commits.webkit.org/234118@main>
Radar WebKit Bug Importer
Comment 7 2021-02-15 15:12:15 PST
<rdar://problem/74367721>
Alexey Shvayka
Comment 8 2021-02-15 15:13:29 PST
(In reply to Yusuke Suzuki from comment #5) > r=me Much obliged! > This hash (// Hash:0x18091000) should be changed. So let's drop it. Dropped.
Sam Weinig
Comment 9 2021-02-15 19:46:37 PST
Awesome.
Alexey Shvayka
Comment 10 2021-03-11 09:16:40 PST
(In reply to Sam Weinig from comment #9) > Awesome. Thanks! --- Oops, I forgot to export WPT before landing.
Note You need to log in before you can comment on or make changes to this bug.