Summary: | Reduce requirements for color types to only conversion to their reference color | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||
Component: | Platform | Assignee: | Sam Weinig <sam> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | darin, koivisto, simon.fraser, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Sam Weinig
2021-02-13 12:04:04 PST
Created attachment 420222 [details]
Patch
Created attachment 420223 [details]
Patch
Comment on attachment 420223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420223&action=review > Source/WebCore/ChangeLog:30 > + â â â â â â â â â â â â â â â â â â â¼ â â â â â â â â â â â â â â â â â â â â â â â â â â â â â â â â â â "ASCII art" that uses UTF-8, eh? > Source/WebCore/platform/graphics/ColorConversion.h:269 > + // results (due to floating point effects) so if this optimation is considered we should ensure we Typo in "optimization" here. > Source/WebCore/platform/graphics/ColorMatrix.h:56 > +template<size_t Columns, size_t Rows> I prefer not to name counts as if they were objects. "Columns" sounds like it is a collection of columns. Maybe ColumnCount? This comes up a lot in argument names, not just template arguments. (In reply to Darin Adler from comment #3) > Comment on attachment 420223 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=420223&action=review > > > Source/WebCore/ChangeLog:30 > > + â â â â â â â â â â â â â â â â â â â¼ â â â â â â â â â â â â â â â â â â â â â â â â â â â â â â â â â â > > "ASCII art" that uses UTF-8, eh? Term of art ;). > > > Source/WebCore/platform/graphics/ColorConversion.h:269 > > + // results (due to floating point effects) so if this optimation is considered we should ensure we > > Typo in "optimization" here. Fixed. > > > Source/WebCore/platform/graphics/ColorMatrix.h:56 > > +template<size_t Columns, size_t Rows> > > I prefer not to name counts as if they were objects. "Columns" sounds like > it is a collection of columns. Maybe ColumnCount? > > This comes up a lot in argument names, not just template arguments. I'll go with ColumnCount/RowCount. Thanks! Created attachment 420226 [details]
Patch
Patch 420226 does not build Created attachment 420227 [details]
Patch
Committed r272837: <https://commits.webkit.org/r272837> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420227 [details]. |